Fix the xml path separator for ps4/5 #1868
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b/288331664
Datadog ReportBranch report: ✅ |
Codecov Report
@@ Coverage Diff @@
## main #1868 +/- ##
==========================================
+ Coverage 57.75% 57.77% +0.02%
==========================================
Files 1915 1915
Lines 95111 95111
==========================================
+ Hits 54931 54952 +21
+ Misses 40180 40159 -21 |
arjungm
reviewed
Oct 31, 2023
| @@ -493,7 +493,13 @@ def MakeLauncher(): | |||
| # The filename is used by MH to deduce the target name. | |||
| xml_filename = f"{target_name}_testoutput.xml" | |||
| if out_path: | |||
| test_result_xml_path = os.path.join(out_path, xml_filename) | |||
| if self.platform in ["ps4", "ps5"]: | |||
There was a problem hiding this comment.
Would be nice to just include all the windows platforms anyway, but maybe the xb1 platforms are being deploy from linux so not sure how applicable this request is. I think NX is fine here too, but we can skip win32 and xb1.
arjungm
approved these changes
Oct 31, 2023
|
The solution proposed here is not ideal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/288331664