Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getOpenedCobaltService method on StarboardBridge. #1861

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

zhongqiliang
Copy link
Contributor

We need to access the opened CobaltService to proactively request Kabuki to process events.

b/306034069

We need to access the opened CobaltService to proactively request
Kabuki to process events.

b/306034069
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Oct 27, 2023

Datadog Report

Branch report: platform_service_update
Commit report: af7241f

cobalt: 0 Failed, 0 New Flaky, 29550 Passed, 1 Skipped, 11m 10.34s Wall Time

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1861 (af7241f) into main (e7bcf65) will increase coverage by 57.76%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           main    #1861       +/-   ##
=========================================
+ Coverage      0   57.76%   +57.76%     
=========================================
  Files         0     1915     +1915     
  Lines         0    95108    +95108     
=========================================
+ Hits          0    54943    +54943     
- Misses        0    40165    +40165     

see 1915 files with indirect coverage changes

@zhongqiliang zhongqiliang merged commit ca3849e into main Oct 27, 2023
351 checks passed
@zhongqiliang zhongqiliang deleted the platform_service_update branch October 27, 2023 19:42
@zhongqiliang zhongqiliang added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Oct 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Oct 27, 2023
We need to access the opened CobaltService to proactively request Kabuki
to process events.

b/306034069

Co-authored-by: Colin Liang <[email protected]>
(cherry picked from commit ca3849e)
zhongqiliang added a commit that referenced this pull request Oct 27, 2023
…ridge. (#1864)

Refer to the original PR: #1861

We need to access the opened CobaltService to proactively request Kabuki
to process events.

b/306034069

Co-authored-by: Colin Liang <[email protected]>
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
We need to access the opened CobaltService to proactively request Kabuki
to process events.

b/306034069

Co-authored-by: Colin Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants