Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raspi 2 monolithic builders #1858

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

niranjanyardi
Copy link
Contributor

@niranjanyardi niranjanyardi commented Oct 27, 2023

Change default raspi builders to modular from monolithic

Raspi- sb version13 , 14 monolithic builders can't be built modularly( as building modularly requires sb15 and above . These builders are removed from the build matrix. Note that sb version 13, 14 are being built by evergreen.

Make raspi-2-skia build modularly.

b/307977106

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1858 (87ecc57) into main (2a4176d) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1858      +/-   ##
==========================================
- Coverage   57.77%   57.77%   -0.01%     
==========================================
  Files        1915     1915              
  Lines       95108    95108              
==========================================
- Hits        54951    54950       -1     
- Misses      40157    40158       +1     

see 6 files with indirect coverage changes

@niranjanyardi niranjanyardi force-pushed the raspi_remove_flags branch 5 times, most recently from 9981dae to c4311d9 Compare October 27, 2023 17:51
Change-Id: I055c890d16ebdf8e894e1515527fd8dfed700956
@niranjanyardi niranjanyardi merged commit 74a344b into youtube:main Oct 27, 2023
338 of 345 checks passed
@niranjanyardi niranjanyardi added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Oct 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Oct 27, 2023
Change default raspi builders to modular from monolithic

Raspi- sb version13 , 14 monolithic builders can't be built modularly(
as building modularly requires sb15 and above . These builders are
removed from the build matrix. Note that sb version 13, 14 are being
built by evergreen.

Make raspi-2-skia build modularly.

b/307977106

(cherry picked from commit 74a344b)
@niranjanyardi niranjanyardi deleted the raspi_remove_flags branch October 27, 2023 21:48
niranjanyardi added a commit that referenced this pull request Oct 27, 2023
Refer to the original PR: #1858

Change default raspi builders to modular from monolithic

Raspi- sb version13 , 14 monolithic builders can't be built modularly(
as building modularly requires sb15 and above . These builders are
removed from the build matrix. Note that sb version 13, 14 are being
built by evergreen.

Make raspi-2-skia build modularly.

b/307977106

Co-authored-by: Niranjan Yardi <[email protected]>
Rongo-JL pushed a commit to Rongo-JL/cobalt that referenced this pull request Dec 19, 2023
Change default raspi builders to modular from monolithic

Raspi- sb version13 , 14 monolithic builders can't be built modularly(
as building modularly requires sb15 and above . These builders are
removed from the build matrix. Note that sb version 13, 14 are being
built by evergreen.

Make raspi-2-skia build modularly.

b/307977106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants