Tunnel mode configurable #1844
Tunnel mode configurable #1844
Conversation
| if (kForceTunnelMode && !enable_tunnel_mode) { | ||
| SB_LOG(INFO) << "`kForceTunnelMode` is set to true, force enabling tunnel" | ||
| if (IsForceTunnelModeEnabled() && !enable_tunnel_mode) { | ||
| SB_LOG(INFO) << "`force_tunnel_mode` is set to true, force enabling tunnel" |
There was a problem hiding this comment.
Format checking: change to
SB_LOG(INFO)
<< "`force_tunnel_mode` is set to true, force enabling tunnel"
<< " mode.";
There was a problem hiding this comment.
Sorry for my late response to you comment.
According to Xiaoming's comment, I think maybe we don't need to enable the tunnel mode forcibly.
If we need to turn tunnel mode on the device for experiment, we will let you know first through email
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1844 +/- ##
=======================================
Coverage 57.77% 57.77%
=======================================
Files 1915 1915
Lines 95108 95116 +8
=======================================
+ Hits 54947 54958 +11
+ Misses 40161 40158 -3 ☔ View full report in Codecov by Sentry. |
| @@ -195,6 +191,13 @@ class PlayerComponentsFactory : public starboard::shared::starboard::player:: | |||
| return (value + alignment - 1) / alignment * alignment; | |||
| } | |||
|
|
|||
| static bool IsForceTunnelModeEnabled() { | |||
| bool force_tunnel_mode = | |||
There was a problem hiding this comment.
We'd prefer this to be controlled by the web app. Do you happen to know if there are any particular devices that we should force enable tunnel mode? We may consider including the devices in our initial experiment.
Please feel free to continue this discussions via email if that's preferred.
There was a problem hiding this comment.
Thanks for the notification and review. Sorry for my really late response.
I will discuss internally and let you know through email if we have a device that needs to enable tunnel mode for the experiment.
| } else { | ||
| SB_DCHECK(!tunnel_mode_enabled_); | ||
| host_->ProcessOutputBuffer(media_codec_bridge_.get(), | ||
| dequeue_output_result); | ||
| } |
There was a problem hiding this comment.
Can you rebase the pr and see if any code here is modified?
There was a problem hiding this comment.
Thanks for the review.
According to Xiaoming's comment, I think maybe we don't need to enable the tunnel mode forcibly.
If we need to turn tunnel mode on the device for experiment, we will let you know first through email.
Rongo-JL
force-pushed
the
tunnel-mode-configurable
branch
from
26e368b
to
033caa8
Compare
Rongo-JL
force-pushed
the
tunnel-mode-configurable
branch
from
033caa8
to
ebd0e67
Compare
Make the tunnel mode be configurable.
b/307998866