[android] Support KEY_MAX_INPUT_SIZE configurable from the webapp #1663

borongc · 2023-09-28T19:19:22Z

Add HTMLVideoElement.setMaxVideoInputSize(max_video_input_size) to allow the web app to explicitly set the maximum size in bytes of a buffer of data for video described by android MediaFormat.
If the setting value is 0, it uses the default value.
This uses the SbThreadLocal to store max_video_input_size, which allows each player to acquire its input size from webapp.
This implementation includes setting max_video_input_size per player, i.e., each player can configure its max_video_input_size.

b/176923480

codecov · 2023-09-28T20:29:45Z

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (6ffd243) 58.52% compared to head (c50d535) 58.49%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
cobalt/dom/html_media_element.cc	0.00%	11 Missing ⚠️
...layer/filter/filter_based_player_worker_handler.cc	33.33%	4 Missing ⚠️
cobalt/media/player/web_media_player_impl.cc	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
- Coverage   58.52%   58.49%   -0.03%     
==========================================
  Files        1902     1900       -2     
  Lines       94536    94225     -311     
==========================================
- Hits        55326    55118     -208     
+ Misses      39210    39107     -103

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java

starboard/android/shared/player_components_factory.h

jasonzhangxx

Overall, the change looks good to me. But as I don't know the context of the bug, I'll let Xiaoming to do the final approval.

starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java

starboard/android/shared/player_components_factory.h

starboard/player.h

cobalt/media/media_module.cc

starboard/android/shared/media_is_video_supported.cc

starboard/extension/player_set_max_video_input_size.h

starboard/android/shared/player_set_max_video_input_size.cc

starboard/android/shared/video_max_video_input_size.cc

1. Add HTMLVideoElement.setMaxVideoInputSize(max_video_input_size) to allow the web app to explicitly set the maximum size in bytes of a buffer of data for video described by android MediaFormat. 2. If the setting value is 0, it uses the default value. 3. This uses the SbThreadLocal to store max_video_input_size, which allows each player to acquire its input size from webapp. 4. This implementation includes setting max_video_input_size per player, i.e., each player can configure its max_video_input_size. b/176923480

) 1. Add HTMLVideoElement.setMaxVideoInputSize(max_video_input_size) to allow the web app to explicitly set the maximum size in bytes of a buffer of data for video described by android MediaFormat. 2. If the setting value is 0, it uses the default value. 3. This uses the SbThreadLocal to store max_video_input_size, which allows each player to acquire its input size from webapp. 4. This implementation includes setting max_video_input_size per player, i.e., each player can configure its max_video_input_size. b/176923480 (cherry picked from commit c39f97a)

…utube#1663) 1. Add HTMLVideoElement.setMaxVideoInputSize(max_video_input_size) to allow the web app to explicitly set the maximum size in bytes of a buffer of data for video described by android MediaFormat. 2. If the setting value is 0, it uses the default value. 3. This uses the SbThreadLocal to store max_video_input_size, which allows each player to acquire its input size from webapp. 4. This implementation includes setting max_video_input_size per player, i.e., each player can configure its max_video_input_size. b/176923480 (cherry picked from commit c39f97a)

) 1. Add HTMLVideoElement.setMaxVideoInputSize(max_video_input_size) to allow the web app to explicitly set the maximum size in bytes of a buffer of data for video described by android MediaFormat. 2. If the setting value is 0, it uses the default value. 3. This uses the SbThreadLocal to store max_video_input_size, which allows each player to acquire its input size from webapp. 4. This implementation includes setting max_video_input_size per player, i.e., each player can configure its max_video_input_size. b/176923480 (cherry picked from commit c39f97a)

…le from the webapp (#2314) Refer to the original PR: #1663 1. Add HTMLVideoElement.setMaxVideoInputSize(max_video_input_size) to allow the web app to explicitly set the maximum size in bytes of a buffer of data for video described by android MediaFormat. 2. If the setting value is 0, it uses the default value. 3. This uses the SbThreadLocal to store max_video_input_size, which allows each player to acquire its input size from webapp. 4. This implementation includes setting max_video_input_size per player, i.e., each player can configure its max_video_input_size. b/176923480 Co-authored-by: Bo-Rong Chen <[email protected]>

…utube#1663) 1. Add HTMLVideoElement.setMaxVideoInputSize(max_video_input_size) to allow the web app to explicitly set the maximum size in bytes of a buffer of data for video described by android MediaFormat. 2. If the setting value is 0, it uses the default value. 3. This uses the SbThreadLocal to store max_video_input_size, which allows each player to acquire its input size from webapp. 4. This implementation includes setting max_video_input_size per player, i.e., each player can configure its max_video_input_size. b/176923480

borongc requested a review from xiaomings September 28, 2023 19:19

borongc force-pushed the buffer_size branch 3 times, most recently from db55c25 to 26a723f Compare October 2, 2023 22:37

sideb0ard reviewed Oct 3, 2023

View reviewed changes

starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java Outdated Show resolved Hide resolved

borongc force-pushed the buffer_size branch 2 times, most recently from 9aed0f1 to 9fcbe93 Compare October 3, 2023 20:45

osagie98 reviewed Oct 3, 2023

View reviewed changes

starboard/android/shared/player_components_factory.h Outdated Show resolved Hide resolved

starboard/android/shared/player_components_factory.h Outdated Show resolved Hide resolved

borongc force-pushed the buffer_size branch 3 times, most recently from 1969a78 to a774843 Compare October 4, 2023 18:09

xiaomings requested a review from jasonzhangxx October 12, 2023 22:19

jasonzhangxx reviewed Oct 16, 2023

View reviewed changes

starboard/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java Outdated Show resolved Hide resolved

starboard/android/shared/player_components_factory.h Outdated Show resolved Hide resolved

borongc force-pushed the buffer_size branch from a774843 to 43de779 Compare October 16, 2023 18:49

borongc force-pushed the buffer_size branch from 43de779 to b99258a Compare November 28, 2023 23:53

borongc changed the title ~~[media] Support KEY_MAX_INPUT_SIZE configurable from MIME attribute~~ [android] Support KEY_MAX_INPUT_SIZE configurable from the webapp Nov 28, 2023

borongc force-pushed the buffer_size branch 5 times, most recently from 769980f to 4f51f63 Compare November 29, 2023 17:56

xiaomings reviewed Dec 5, 2023

View reviewed changes

starboard/player.h Outdated Show resolved Hide resolved

cobalt/media/media_module.cc Outdated Show resolved Hide resolved

starboard/android/shared/media_is_video_supported.cc Outdated Show resolved Hide resolved

borongc force-pushed the buffer_size branch 7 times, most recently from 0399825 to 103a31c Compare December 8, 2023 20:39

borongc force-pushed the buffer_size branch from 6e81cfa to 311bb88 Compare January 18, 2024 18:51

borongc added the on_device label Jan 23, 2024

borongc force-pushed the buffer_size branch 5 times, most recently from 92bd390 to 0e6d2e7 Compare January 24, 2024 22:55

xiaomings reviewed Jan 25, 2024

View reviewed changes

starboard/extension/player_set_max_video_input_size.h Outdated Show resolved Hide resolved

starboard/extension/player_set_max_video_input_size.h Outdated Show resolved Hide resolved

starboard/extension/player_set_max_video_input_size.h Outdated Show resolved Hide resolved

borongc force-pushed the buffer_size branch 4 times, most recently from 026fd11 to a7392f3 Compare January 26, 2024 00:25

borongc requested a review from xiaomings January 26, 2024 17:37

xiaomings reviewed Jan 26, 2024

View reviewed changes

starboard/android/shared/player_set_max_video_input_size.cc Outdated Show resolved Hide resolved

starboard/android/shared/player_set_max_video_input_size.cc Outdated Show resolved Hide resolved

borongc force-pushed the buffer_size branch 3 times, most recently from 27a4160 to cfcb610 Compare January 26, 2024 23:56

borongc requested a review from xiaomings January 26, 2024 23:57

xiaomings approved these changes Jan 27, 2024

View reviewed changes

starboard/android/shared/player_set_max_video_input_size.cc Show resolved Hide resolved

starboard/android/shared/video_max_video_input_size.cc Outdated Show resolved Hide resolved

borongc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Jan 27, 2024

borongc force-pushed the buffer_size branch from cfcb610 to c50d535 Compare January 27, 2024 04:03

borongc merged commit c39f97a into youtube:main Jan 27, 2024
371 of 376 checks passed

borongc deleted the buffer_size branch January 27, 2024 06:00

cobalt-github-releaser-bot mentioned this pull request Jan 27, 2024

Cherry pick PR #1663: [android] Support KEY_MAX_INPUT_SIZE configurable from the webapp #2314

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android] Support KEY_MAX_INPUT_SIZE configurable from the webapp #1663

[android] Support KEY_MAX_INPUT_SIZE configurable from the webapp #1663

borongc commented Sep 28, 2023 •

edited

Loading

codecov bot commented Sep 28, 2023 •

edited

Loading

jasonzhangxx left a comment

[android] Support KEY_MAX_INPUT_SIZE configurable from the webapp #1663

[android] Support KEY_MAX_INPUT_SIZE configurable from the webapp #1663

Conversation

borongc commented Sep 28, 2023 • edited Loading

codecov bot commented Sep 28, 2023 • edited Loading

Codecov Report

jasonzhangxx left a comment

Choose a reason for hiding this comment

borongc commented Sep 28, 2023 •

edited

Loading

codecov bot commented Sep 28, 2023 •

edited

Loading