Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup mime attribute of enableaudiodevicecallback #1518

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Sep 8, 2023

Remove this attribute as it is not used.

b/216483296

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #1518 (db8a647) into main (e8a8ca6) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

❗ Current head db8a647 differs from pull request most recent head 6651bde. Consider uploading reports for the commit 6651bde to get more accurate results

@@            Coverage Diff             @@
##             main    #1518      +/-   ##
==========================================
- Coverage   57.55%   57.54%   -0.01%     
==========================================
  Files        1905     1905              
  Lines       94680    94680              
==========================================
- Hits        54489    54483       -6     
- Misses      40191    40197       +6     

see 12 files with indirect coverage changes

@borongc borongc force-pushed the cleanup_mime branch 2 times, most recently from 73cc23b to c06f0c2 Compare September 9, 2023 18:20
@borongc borongc force-pushed the cleanup_mime branch 2 times, most recently from bc767ce to 9627e35 Compare September 9, 2023 18:53
Remove this attribute as it is not used.

b/216483296
Defalut enable_audio_device_callback as true.

b/216483296
Remove this attribute as it is not used.

b/216483296
@borongc borongc merged commit ef7ab40 into youtube:main Sep 11, 2023
340 checks passed
@borongc borongc deleted the cleanup_mime branch September 11, 2023 21:24
@borongc borongc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Feb 28, 2024
cobalt-github-releaser-bot pushed a commit that referenced this pull request Feb 28, 2024
Remove this attribute as it is not used.

b/216483296

(cherry picked from commit ef7ab40)
borongc added a commit that referenced this pull request Mar 2, 2024
Remove this attribute as it is not used.

b/216483296

(cherry picked from commit ef7ab40)
borongc added a commit that referenced this pull request Mar 2, 2024
Remove this attribute as it is not used.

b/216483296

(cherry picked from commit ef7ab40)
borongc added a commit that referenced this pull request Mar 18, 2024
…back (#2508)

Refer to the original PR: #1518

Remove this attribute as it is not used.

b/216483296

Co-authored-by: Bo-Rong Chen <[email protected]>
borongc added a commit to borongc/cobalt that referenced this pull request Apr 9, 2024
Remove this attribute as it is not used.

b/216483296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants