Cherry pick PR #1498: Add check-xml pre-commit #1502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driving use case is to validate telemetry xml metadata configuration files, all found under tools/metrics. These are the files used to propagate metadata about the metrics inside Google. b/296056775 Change-Id: I511a4311b0ce931e7ab3dc945c7b24f3f1a2dc7a (cherry picked from commit a7958f3)
joeltine
approved these changes
Sep 6, 2023
andrewsavage1
requested changes
Sep 20, 2023
The driving use case is to validate telemetry xml metadata configuration files, all found under tools/metrics. These are the files used to propagate metadata about the metrics inside Google. b/296056775 Change-Id: I511a4311b0ce931e7ab3dc945c7b24f3f1a2dc7a (cherry picked from commit a7958f3)
| url | ||
| )/ | ||
| | | ||
| components/update_client/((?!cobalt).)*$ | ||
| | | ||
| # Ignore everything under tools/metrics _except_ xml files. We need | ||
| # those validated to keep the telemetry/metrics pipeline working. | ||
| tools/metrics/(.*\.(?!xml$)[^/]*|[^/.]+)$| |
There was a problem hiding this comment.
I think this is the only regex you want to add, the rest seem to be unrelated to your original change
There was a problem hiding this comment.
It's more than I added originally, but I had to merge conflicts because previous changes to this file were not CP'd into 24.
There was a problem hiding this comment.
There was a problem hiding this comment.
No. Another option is not to CP this at all. Is a presubmit like this necessary in the 24 branch?
There was a problem hiding this comment.
Yeah, if you don't expect significant changes to xml files on this branch, it makes sense to forgo this change—especially as they'll likely first go through trunk where we have this check in place already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #1498
The driving use case is to validate telemetry xml metadata configuration files, all found under tools/metrics. These are the files used to propagate metadata about the metrics inside Google.
b/296056775
Change-Id: I511a4311b0ce931e7ab3dc945c7b24f3f1a2dc7a