Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove raspi-2 -fno-exception hack. #1490

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Remove raspi-2 -fno-exception hack. #1490

merged 2 commits into from
Sep 12, 2023

Conversation

y4vor
Copy link
Contributor

@y4vor y4vor commented Sep 6, 2023

b/219073252

Change-Id: Ie8faf54383b627cfc5502251cd86ee4fbae4aa71

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1490 (a03195d) into main (419286c) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
- Coverage   57.56%   57.54%   -0.02%     
==========================================
  Files        1905     1905              
  Lines       94680    94680              
==========================================
- Hits        54501    54483      -18     
- Misses      40179    40197      +18     

see 8 files with indirect coverage changes

- Remove raspi-2 -fno-exception hack.
- Remove exception config from nplb.
- Remove exception flag and corresponding source for libcxxabi.

b/219073252

Change-Id: Ie8faf54383b627cfc5502251cd86ee4fbae4aa71
@andrewsavage1
Copy link
Contributor

Added on_device label—let's get a sense of if all of those look good, but I don't see any issues with the change

@y4vor y4vor merged commit 4a5738d into youtube:main Sep 12, 2023
379 of 401 checks passed
andrewsavage1 added a commit that referenced this pull request Sep 13, 2023
andrewsavage1 added a commit that referenced this pull request Sep 13, 2023
This reverts commit 4a5738d.

Seems to be causing many raspi tests to fail.

b/219073252
@y4vor y4vor deleted the no_exception branch May 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants