Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow DecodedAudio ctor to accept a Buffer object #1486

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Sep 5, 2023

Add a DecodedAudio ctor to accept a Buffer object without extra copy.

b/275199195

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #1486 (01c3fd1) into main (5e67ace) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 01c3fd1 differs from pull request most recent head e5efc03. Consider uploading reports for the commit e5efc03 to get more accurate results

@@            Coverage Diff             @@
##             main    #1486      +/-   ##
==========================================
+ Coverage   56.37%   56.39%   +0.02%     
==========================================
  Files        1902     1902              
  Lines       94607    94612       +5     
==========================================
+ Hits        53330    53352      +22     
+ Misses      41277    41260      -17     
Files Changed Coverage Δ
...d/shared/starboard/player/decoded_audio_internal.h 100.00% <ø> (ø)
.../shared/starboard/player/decoded_audio_internal.cc 86.93% <100.00%> (+0.33%) ⬆️

... and 5 files with indirect coverage changes

@borongc borongc merged commit d8fe96d into youtube:main Sep 6, 2023
340 checks passed
@borongc borongc deleted the audio_buffer branch September 6, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants