Cherry pick PR #1457: Remove sb_is_modular from base_configuration.gni #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
approved these changes
Aug 30, 2023
niranjanyardi
force-pushed
the
24.lts.1+-1457
branch
from
883f793
to
b365fdb
Compare
b/295399926 sb_is_modular shouldn't be set by the platform, it's a derived flag already defined in another location. (cherry picked from commit 19e5854)
niranjanyardi
force-pushed
the
24.lts.1+-1457
branch
from
b365fdb
to
57b1408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #1457
b/295399926
sb_is_modular shouldn't be set by the platform, it's a derived flag already defined in another location.