Cherry pick PR #1329: Change libopus to not export symbols #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
approved these changes
Aug 22, 2023
Forces OPUS_EXPORT to be defined, so that later config code does not override the default symbol visibility. This prevents leaking the symbols across module boundaries in modular builds. b/296578318 (cherry picked from commit ca33e8e)
kaidokert
force-pushed
the
24.lts.1+-1329
branch
from
85fe4cf
to
ebfa667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #1329
Forces OPUS_EXPORT to be defined, so that later config code does not override the default symbol visibility.
This prevents leaking the symbols across module boundaries in modular builds.
b/296578318