Cherry pick PR #1206: Set sb_is_modular appropriately, build linux using sb_is_modular #1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
approved these changes
Aug 11, 2023
niranjanyardi
approved these changes
Aug 16, 2023
niranjanyardi
force-pushed
the
24.lts.1+-1206
branch
3 times, most recently
from
0284300
to
7d7944d
Compare
b/294267479 b/294230277 Set sb_is_modular = sb_is_evergreen || build_with_separate-cobalt_toolchain Set sb_is_evergreen = !build_with_separate-cobalt_toolchain This PR forces linux-modular builds to be built with sb_is_modular = true and sb_is_evergreen = false Change-Id: Ie9464ce4350023063f2ca0dfbecb2e917cd4ba3b (cherry picked from commit 5d61db9)
niranjanyardi
force-pushed
the
24.lts.1+-1206
branch
from
7d7944d
to
77ce20d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #1206
b/294267479
b/294230277
Set sb_is_modular = sb_is_evergreen || build_with_separate-cobalt_toolchain
Set sb_is_evergreen = !build_with_separate-cobalt_toolchain
This PR forces linux-modular builds to be built with sb_is_modular = true and sb_is_evergreen = false
Change-Id: Ie9464ce4350023063f2ca0dfbecb2e917cd4ba3b