Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Watchdog] Add clients lists as an optional parameter to GetWatchdogViolations() #1182

Merged
merged 1 commit into from
Aug 9, 2023
Merged

[Watchdog] Add clients lists as an optional parameter to GetWatchdogViolations() #1182

merged 1 commit into from
Aug 9, 2023

Conversation

sherryzy
Copy link
Contributor

@sherryzy sherryzy commented Aug 7, 2023

b/287302949

@sherryzy sherryzy marked this pull request as draft August 8, 2023 00:29
@sherryzy sherryzy marked this pull request as ready for review August 8, 2023 01:59
@codecov
Copy link

codecov bot commented Aug 8, 2023 •
edited
Loading

Codecov Report

Merging #1182 (7a61073) into main (79e5003) will increase coverage by 0.06%.
Report is 6 commits behind head on main.
The diff coverage is 84.74%.

@@            Coverage Diff             @@
##             main    #1182      +/-   ##
==========================================
+ Coverage   56.47%   56.53%   +0.06%     
==========================================
  Files        1899     1899              
  Lines       94216    94295      +79     
==========================================
+ Hits        53205    53312     +107     
+ Misses      41011    40983      -28
Files Changed Coverage Δ
cobalt/h5vcc/h5vcc_crash_log.cc 0.00% <0.00%> (ø)
cobalt/h5vcc/h5vcc_crash_log.h 100.00% <ø> (ø)
cobalt/watchdog/watchdog.cc 88.66% <100.00%> (+1.16%) ⬆️

... and 20 files with indirect coverage changes

@sherryzy sherryzy changed the title Add clients lists as an optional parameter to GetWatchdogViolations() [Watchdog] Add clients lists as an optional parameter to GetWatchdogViolations() Aug 8, 2023
briantting
briantting requested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@briantting briantting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's logically sound but we can reduce the number of file I/O operations by just relying on the in memory violations map. This will also be simpler / easier to read code.

briantting
briantting approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@briantting briantting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's logically sound but we can reduce the number of file I/O operations by just relying on the in memory violations map. This will also be simpler / easier to read code.

@sherryzy sherryzy merged commit a0d3e07 into youtube:main Aug 9, 2023
333 checks passed
@sherryzy sherryzy added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Aug 9, 2023
@cobalt-github-releaser-bot cobalt-github-releaser-bot mentioned this pull request Aug 9, 2023
Merged
cobalt-github-releaser-bot pushed a commit that referenced this pull request Aug 9, 2023
@sherryzy @anonymous1-me
[Watchdog] Add clients lists as an optional parameter to GetWatchdogV…
c0a2e9f 
…iolations() (#1182)

b/287302949

(cherry picked from commit a0d3e07)
sherryzy added a commit that referenced this pull request Aug 9, 2023
@cobalt-github-releaser-bot @sherryzy
Cherry pick PR #1182: [Watchdog] Add clients lists as an optional par…
5b4f70e 
…ameter to GetWatchdogViolations() (#1195)

Refer to the original PR: #1182

b/287302949

Co-authored-by: Sherry Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briantting briantting briantting approved these changes

Assignees
No one assigned
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sherryzy @briantting