Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xbox builders #1168

Closed
wants to merge 2 commits into from
Closed

Add Xbox builders #1168

wants to merge 2 commits into from

Conversation

kaidokert
Copy link
Member

Adds build configs to Xbox

b/266878119

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (ebd0e67) 58.55% compared to head (6070faa) 58.56%.
Report is 34 commits behind head on main.

Files Patch % Lines
starboard/shared/posix/page_internal.cc 63.15% 7 Missing ⚠️
cobalt/dom/source_buffer_metrics.cc 0.00% 3 Missing ⚠️
starboard/elf_loader/program_table.cc 81.25% 3 Missing ⚠️
starboard/elf_loader/exported_symbols.cc 81.81% 2 Missing ⚠️
starboard/common/time.cc 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1168    +/-   ##
========================================
  Coverage   58.55%   58.56%            
========================================
  Files        1914     1911     -3     
  Lines       94432    94585   +153     
========================================
+ Hits        55299    55390    +91     
- Misses      39133    39195    +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TyHolc TyHolc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the build failures it looks like this might be missing either a UWP SDK or Xbox SDK

@kaidokert
Copy link
Member Author

Based on the build failures it looks like this might be missing either a UWP SDK or Xbox SDK

Because it's still being executed in the wrong container - i put a todo / comment in the JSON file. I'd appreciate if someone can pick this up and land it - i won't make much forward progress in the next few days.

@kaidokert kaidokert changed the title Add XboxOne builders Add Xbox builders Aug 24, 2023
Adds build configs to Xbox

b/266878119
.github/workflows/xb1.yaml Outdated Show resolved Hide resolved
@kaidokert kaidokert closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants