Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PR #807: [android] Reset frame rate estimator when the stream fps changed (#807) #1062

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

mingchou
Copy link
Contributor

Cherry pick PR #807: [android] Reset frame rate estimator when the stream fps changed (#807)

Refer to the original PR: #807

When playing a stream, the key operating rate is set to MediaCodec for resource planning. It's calculated by the playback rate and the estimated fps. While the latter is calculated by the number of rendered frames in duration. When the stream fps is changed, the estimated fps will be affected by the frames already rendered with the old fps and slowly adjusted to the new fps. This may lead to insufficient resources prepared for the stream and cause some performance issues.

b/290409989

Change-Id: I5126794d0ac98d29fc8405359bcb4f62dc444308

… the stream fps changed (youtube#807)

Refer to the original PR: youtube#807

When playing a stream, the key operating rate is set to MediaCodec for
resource planning. It's calculated by the playback rate and the
estimated fps. While the latter is calculated by the number of
rendered frames in duration. When the stream fps is changed, the
estimated fps will be affected by the frames already rendered with the
old fps and slowly adjusted to the new fps. This may lead to
insufficient resources prepared for the stream and cause some
performance issues.

b/290409989

Change-Id: I5126794d0ac98d29fc8405359bcb4f62dc444308
@kaidokert
Copy link
Member

Hi - i just noticed your question about the cherry-pick. Generally there are no more planned releases from 23.lts.1+, the last release was 23.lts.5. 23 branch is considered pretty much finished at this point.

We can still of course apply the change, especially as this is a small and clean bug fix, but we do not expect this to get deployed.

@mingchou
Copy link
Contributor Author

Thanks for the information. Wondering will the existing devices upgraded to 24* in the future or if they will stay in the 23 latest release?

@kaidokert
Copy link
Member

Thanks for the information. Wondering will the existing devices upgraded to 24* in the future or if they will stay in the 23 latest release?

It depends on the device. For Cobalt 24 supports Starboard versions 13, 14 and 15, so any older devices on Starboard 12 and older wouldn't be upgradeable anymore. Of course, for devices that get updates through appstores ( e.g Android TV), they all should eventually get updates.

@kaidokert kaidokert merged commit 44d28a4 into youtube:23.lts.1+ Jul 29, 2023
250 checks passed
@kaidokert
Copy link
Member

I've applied the fix here - and thanks again for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants