Skip to content

Commit

Permalink
Remove loader executable copy action for windows based modular platfo…
Browse files Browse the repository at this point in the history
…rms (#1512)

b/246854012

The copy action has to be removed for windows based platforms as the
executable extension is unknown in BUILDCONFIG

(cherry picked from commit fe33a21)
  • Loading branch information
niranjanyardi committed Sep 23, 2023
1 parent 705ef06 commit ef16945
Showing 1 changed file with 10 additions and 6 deletions.
16 changes: 10 additions & 6 deletions starboard/build/config/BUILDCONFIG.gn
Original file line number Diff line number Diff line change
Expand Up @@ -409,9 +409,11 @@ template("shared_library") {
forward_variables_from(invoker, [ "testonly" ])
deps = [
":${actual_target_name}_loader($starboard_toolchain)",
":${actual_target_name}_loader_copy($starboard_toolchain)",
":${actual_target_name}_loader_install($starboard_toolchain)",
]
if (!is_host_win) {
deps += [ ":${actual_target_name}_loader_copy($starboard_toolchain)" ]
}
}
if (current_toolchain == starboard_toolchain) {
executable("${actual_target_name}_loader") {
Expand Down Expand Up @@ -445,11 +447,13 @@ template("shared_library") {
deps += [ "//starboard:starboard_platform_group_install($starboard_toolchain)" ]
}
}
copy("${actual_target_name}_loader_copy") {
forward_variables_from(invoker, [ "testonly" ])
sources = [ "$root_out_dir/${actual_target_name}_loader" ]
outputs = [ "$root_build_dir/${actual_target_name}_loader" ]
deps = [ ":${actual_target_name}_loader" ]
if (!is_host_win) {
copy("${actual_target_name}_loader_copy") {
forward_variables_from(invoker, [ "testonly" ])
sources = [ "$root_out_dir/${actual_target_name}_loader" ]
outputs = [ "$root_build_dir/${actual_target_name}_loader" ]
deps = [ ":${actual_target_name}_loader" ]
}
}
}
}
Expand Down

0 comments on commit ef16945

Please sign in to comment.