[XB1] Fix skipped OnDecoderDrained task. (#1765)

b/284359403 (cherry picked from commit 8eea4c9)
youtube · Nov 6, 2023 · d485982 · d485982
1 parent 6586e24
commit d485982
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/starboard/xb1/shared/gpu_base_video_decoder.cc b/starboard/xb1/shared/gpu_base_video_decoder.cc
@@ -593,17 +593,13 @@ void GpuVideoDecoderBase::OnDecoderDrained() {
             decoder_behavior_.load() == kResettingDecoder);
 
   is_waiting_frame_after_drain_ = true;
-  if (decoder_behavior_.load() == kResettingDecoder || error_occured_) {
-    return;
-  }
 
   if (!BelongsToDecoderThread()) {
     decoder_thread_->job_queue()->Schedule(
         std::bind(&GpuVideoDecoderBase::OnDecoderDrained, this));
     return;
   }
 
-  SB_DCHECK(written_inputs_.empty());
   if (decoder_behavior_.load() == kEndingStream) {
     decoder_status_cb_(kBufferFull, VideoFrame::CreateEOSFrame());
   }
@@ -688,6 +684,9 @@ void GpuVideoDecoderBase::DrainDecoder() {
   if (!is_drain_decoder_called_) {
     is_drain_decoder_called_ = true;
     DrainDecoderInternal();
+    // DrainDecoderInternal is sync command, after it finished, we can be sure
+    // that drain really completed.
+    OnDecoderDrained();
   }
 }
 

diff --git a/starboard/xb1/shared/gpu_base_video_decoder.h b/starboard/xb1/shared/gpu_base_video_decoder.h
@@ -218,7 +218,7 @@ class GpuVideoDecoderBase
 
   Mutex frame_buffers_mutex_;
   ConditionVariable frame_buffers_condition_;
-  // static std::vector<scoped_refptr<GpuFrameBuffer>> s_frame_buffers_;
+
  private:
   class GPUDecodeTargetPrivate;