Add ErrorAction to Win Dockerfiles. (#1919)

b/309502154
youtube · Nov 7, 2023 · d24c2c2 · d24c2c2
1 parent 4a1d1cc
commit d24c2c2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/docker/windows/base/build/Dockerfile b/docker/windows/base/build/Dockerfile
@@ -16,7 +16,8 @@
 ARG FROM_IMAGE
 FROM ${FROM_IMAGE}
 
-SHELL ["powershell", "-ExecutionPolicy", "unrestricted", "-Command"]
+SHELL ["powershell", "-ExecutionPolicy", "Unrestricted", "-Command", `
+       "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
 
 # Helper script for quick delete operations in windows
 COPY ./fast-win-rmdir.cmd /fast-win-rmdir.cmd

diff --git a/docker/windows/base/visualstudio2022/Dockerfile b/docker/windows/base/visualstudio2022/Dockerfile
@@ -19,7 +19,8 @@ FROM ${FROM_IMAGE}
 # Dockerfile for image used to install Visual Studio.
 # WARNING: Changes to this file will result in an extremely long image rebuild.
 
-SHELL ["powershell", "-ExecutionPolicy", "unrestricted", "-Command"]
+SHELL ["powershell", "-ExecutionPolicy", "Unrestricted", "-Command", `
+       "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"]
 
 RUN mkdir C:\TEMP;`
     Write-Host ('Downloading vs_buildtools.exe');`