Skip to content

Commit

Permalink
Cherry pick PR #2905: Fix docsite generation for SbPlayer functions (#…
Browse files Browse the repository at this point in the history
…2906)

Refer to the original PR: #2905

Noticed that SbPlayerCreate and SbPlayerSeek functions were missing
from:

https://developers.google.com/youtube/cobalt/docs/reference/starboard/modules/player

turns out to be simply additional spaces in the comments.

b/333721484

Co-authored-by: thorsten sideb0ard <[email protected]>
  • Loading branch information
cobalt-github-releaser-bot and sideb0ard authored Apr 11, 2024
1 parent 533246c commit d0bba1a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions starboard/player.h
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,6 @@ static SB_C_INLINE bool SbPlayerIsValid(SbPlayer player) {
// video will never adapt to resolution higher than 1920x1080 or frame per
// second higher than 15 fps. When the maximums are unknown, this will be set
// to NULL.

//
// |sample_deallocator_func|: If not |NULL|, the player calls this function
// on an internal thread to free the sample buffers passed into
Expand Down Expand Up @@ -419,7 +418,6 @@ static SB_C_INLINE bool SbPlayerIsValid(SbPlayer player) {
// If |NULL| is passed to any of the callbacks (|sample_deallocator_func|,
// |decoder_status_func|, |player_status_func|, or |player_error_func| if it
// applies), then |kSbPlayerInvalid| must be returned.

SB_EXPORT SbPlayer
SbPlayerCreate(SbWindow window,
const SbPlayerCreationParam* creation_param,
Expand Down Expand Up @@ -489,7 +487,6 @@ SB_EXPORT void SbPlayerDestroy(SbPlayer player);
// when SbPlayerSeek was called. To be very specific, once SbPlayerSeek has
// been called with ticket X, a client should ignore all
// |SbPlayerDecoderStatusFunc| calls that do not pass in ticket X.

#if SB_API_VERSION >= 15
SB_EXPORT void SbPlayerSeek(SbPlayer player,
SbTime seek_to_timestamp,
Expand Down

0 comments on commit d0bba1a

Please sign in to comment.