Don't use starboard_platform_group install target for bundled platfor…

…ms (#1489) b/298729481 Add modular loader dependency on starboard install target for platforms which don't have bundle test targets
youtube · Sep 7, 2023 · ccede65 · ccede65
1 parent 7f2187a
commit ccede65
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/starboard/build/config/BUILDCONFIG.gn b/starboard/build/config/BUILDCONFIG.gn
@@ -522,8 +522,10 @@ template("shared_library") {
         deps = [
           ":$original_target_name($cobalt_toolchain)",
           "//starboard:starboard_platform_group($starboard_toolchain)",
-          "//starboard:starboard_platform_group_install($starboard_toolchain)",
         ]
+        if (!separate_install_targets_for_bundling) {
+          deps += [ "//starboard:starboard_platform_group_install($starboard_toolchain)" ]
+        }
       }
       copy("${actual_target_name}_loader_copy") {
         forward_variables_from(invoker, [ "testonly" ])

diff --git a/starboard/raspi/2/platform_configuration/configuration.gni b/starboard/raspi/2/platform_configuration/configuration.gni
@@ -19,6 +19,8 @@ if (current_toolchain != default_toolchain ||
 
   sb_evergreen_compatible_use_libunwind = true
   sb_is_evergreen_compatible = true
+}
 
+if (!build_with_separate_cobalt_toolchain) {
   separate_install_targets_for_bundling = true
 }