Cherry pick PR #629: Remove Android internal input_events_filter (#643)

Co-authored-by: Colin Liang <[email protected]> Co-authored-by: Colin Liang <[email protected]>
youtube · Jun 15, 2023 · c4d8737 · c4d8737
1 parent bea94a1
commit c4d8737
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 21 deletions.
diff --git a/starboard/android/shared/BUILD.gn b/starboard/android/shared/BUILD.gn
@@ -439,14 +439,6 @@ static_library("starboard_platform") {
     "//third_party/opus",
   ]
 
-  if (is_internal_build) {
-    sources += [
-      "//internal/starboard/android/shared/internal/input_events_filter.cc",
-      "//internal/starboard/android/shared/internal/input_events_filter.h",
-    ]
-    defines = [ "STARBOARD_INPUT_EVENTS_FILTER" ]
-  }
-
   if (sb_is_evergreen_compatible) {
     sources -= [
       "crash_handler.cc",

diff --git a/starboard/android/shared/application_android.cc b/starboard/android/shared/application_android.cc
@@ -436,12 +436,6 @@ bool ApplicationAndroid::SendAndroidKeyEvent(
     const GameActivityKeyEvent* event) {
   bool result = false;
 
-#ifdef STARBOARD_INPUT_EVENTS_FILTER
-  if (!input_events_filter_.ShouldProcessKeyEvent(event)) {
-    return result;
-  }
-#endif
-
   ScopedLock lock(input_mutex_);
   if (!input_events_generator_) {
     return false;

diff --git a/starboard/android/shared/application_android.h b/starboard/android/shared/application_android.h
@@ -22,9 +22,6 @@
 #include <vector>
 
 #include "game-activity/GameActivity.h"
-#ifdef STARBOARD_INPUT_EVENTS_FILTER
-#include "internal/starboard/android/shared/internal/input_events_filter.h"
-#endif
 #include "starboard/android/shared/input_events_generator.h"
 #include "starboard/android/shared/jni_env_ext.h"
 #include "starboard/atomic.h"
@@ -168,10 +165,6 @@ class ApplicationAndroid
   Mutex input_mutex_;
   scoped_ptr<InputEventsGenerator> input_events_generator_;
 
-#ifdef STARBOARD_INPUT_EVENTS_FILTER
-  internal::InputEventsFilter input_events_filter_;
-#endif
-
   bool last_is_accessibility_high_contrast_text_enabled_;
 
   jobject resource_overlay_;