Move download_from_gcs to Starboard (#4086)

Removes reverse dependency from Starboard to Cobalt b/364421874
youtube · Sep 4, 2024 · c21c5d0 · c21c5d0
1 parent 5f6f700
commit c21c5d0
Show file tree

Hide file tree

Showing 11 changed files with 7 additions and 7 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -176,7 +176,7 @@ repos:
         always_run: true
         stages: [push]
         additional_dependencies: [certifi]
-        args: [-m, unittest, cobalt/tools/download_from_gcs_test.py]
+        args: [-m, unittest, starboard/tools/download_from_gcs_test.py]
     -   id: test-python3-compatibility
         name: Test Python 3 Compatibility
         description: Checks that scripts can be run in Python 3

diff --git a/cobalt/media/testing/BUILD.gn b/cobalt/media/testing/BUILD.gn
@@ -17,7 +17,7 @@ import("//cobalt/media/testing/data/sha1_files.gni")
 action("cobalt_media_download_test_data") {
   install_content = true
 
-  script = "//cobalt/tools/download_from_gcs.py"
+  script = "//starboard/tools/download_from_gcs.py"
 
   sha_sources = []
   foreach(sha1_file, sha1_files) {

diff --git a/cobalt/renderer/BUILD.gn b/cobalt/renderer/BUILD.gn
@@ -500,7 +500,7 @@ copy("renderer_copy_lottie_test_data") {
 action("renderer_download_lottie_test_data") {
   install_content = true
 
-  script = "//cobalt/tools/download_from_gcs.py"
+  script = "//starboard/tools/download_from_gcs.py"
 
   inputs = [
     "$_lottie_resource_path/finger_print-expected.png.sha1",

diff --git a/components/crx_file/BUILD.gn b/components/crx_file/BUILD.gn
@@ -35,7 +35,7 @@ if (is_starboard) {
   action("crx_file_download_test_data") {
     install_content = true
 
-    script = "//cobalt/tools/download_from_gcs.py"
+    script = "//starboard/tools/download_from_gcs.py"
 
     sha_sources = []
     foreach(sha1_file, sha1_files) {

diff --git a/download_resources.py b/download_resources.py
@@ -22,7 +22,7 @@
 except ImportError:
   import urllib2 as urllib
 
-from cobalt.tools import download_from_gcs
+from starboard.tools import download_from_gcs
 
 
 def DownloadGerritCommitMsgHook(force=False):

diff --git a/starboard/shared/starboard/player/BUILD.gn b/starboard/shared/starboard/player/BUILD.gn
@@ -34,7 +34,7 @@ static_library("video_dmp") {
 action("player_download_test_data") {
   install_content = true
 
-  script = "//cobalt/tools/download_from_gcs.py"
+  script = "//starboard/tools/download_from_gcs.py"
 
   sha_sources = []
   foreach(sha1_file, sha1_files) {

diff --git a/cobalt/tools/download_from_gcs.py → starboard/tools/download_from_gcs.py b/cobalt/tools/download_from_gcs.py → starboard/tools/download_from_gcs.py
diff --git a/cobalt/tools/download_from_gcs_test.py → starboard/tools/download_from_gcs_test.py b/cobalt/tools/download_from_gcs_test.py → starboard/tools/download_from_gcs_test.py
@@ -18,7 +18,7 @@
 import tempfile
 import unittest
 
-from cobalt.tools import download_from_gcs
+from starboard.tools import download_from_gcs
 
 _BUCKET = 'chromium-clang-format'
 _HASH_FILE_EXT = '.sha1'

diff --git a/...sting/download_from_gcs/clang-format.sha1 → ...sting/download_from_gcs/clang-format.sha1 b/...sting/download_from_gcs/clang-format.sha1 → ...sting/download_from_gcs/clang-format.sha1
diff --git a/...d_from_gcs/test_dir/clang-format.exe.sha1 → ...d_from_gcs/test_dir/clang-format.exe.sha1 b/...d_from_gcs/test_dir/clang-format.exe.sha1 → ...d_from_gcs/test_dir/clang-format.exe.sha1
diff --git a/...nload_from_gcs/test_dir/clang-format.sha1 → ...nload_from_gcs/test_dir/clang-format.sha1 b/...nload_from_gcs/test_dir/clang-format.sha1 → ...nload_from_gcs/test_dir/clang-format.sha1