Cherry pick PR #3084: Add idl definition for PersistentSettingLogtrac…

…eEnable getter and setter (#3092) Refer to the original PR: #3084 Add idl definition for PersistentSettingLogtraceEnable getter and setter. Tested with devtools on Cobalt on linux. b/334122726 Change-Id: I22a881f99af3c05eadc251881cf167d3e0934c0e Co-authored-by: Anton <[email protected]>
youtube · Apr 26, 2024 · 741bbe0 · 741bbe0
1 parent ac95f2b
commit 741bbe0
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/cobalt/h5vcc/h5vcc_crash_log.cc b/cobalt/h5vcc/h5vcc_crash_log.cc
@@ -176,6 +176,17 @@ void H5vccCrashLog::SetPersistentSettingWatchdogCrash(bool can_trigger_crash) {
   if (watchdog) watchdog->SetPersistentSettingWatchdogCrash(can_trigger_crash);
 }
 
+bool H5vccCrashLog::GetPersistentSettingLogtraceEnable() {
+  watchdog::Watchdog* watchdog = watchdog::Watchdog::GetInstance();
+  if (watchdog) return watchdog->GetPersistentSettingLogtraceEnable();
+  return false;
+}
+
+void H5vccCrashLog::SetPersistentSettingLogtraceEnable(bool enable_logtrace) {
+  watchdog::Watchdog* watchdog = watchdog::Watchdog::GetInstance();
+  if (watchdog) watchdog->SetPersistentSettingLogtraceEnable(enable_logtrace);
+}
+
 bool H5vccCrashLog::LogEvent(const std::string& event) {
   watchdog::Watchdog* watchdog = watchdog::Watchdog::GetInstance();
   if (!watchdog) {

diff --git a/cobalt/h5vcc/h5vcc_crash_log.h b/cobalt/h5vcc/h5vcc_crash_log.h
@@ -60,6 +60,10 @@ class H5vccCrashLog : public script::Wrappable {
 
   void SetPersistentSettingWatchdogCrash(bool can_trigger_crash);
 
+  bool GetPersistentSettingLogtraceEnable();
+
+  void SetPersistentSettingLogtraceEnable(bool enable_logtrace);
+
   bool LogEvent(const std::string& event);
 
   script::Sequence<std::string> GetLogTrace();

diff --git a/cobalt/h5vcc/h5vcc_crash_log.idl b/cobalt/h5vcc/h5vcc_crash_log.idl
@@ -109,6 +109,14 @@ interface H5vccCrashLog {
   // Watchdog violation will trigger a crash.
   void setPersistentSettingWatchdogCrash(boolean can_trigger_crash);
 
+  // Gets a persistent setting that determines whether or not
+  // events emitted by logEvent() are saved in Cobalt buffer.
+  boolean getPersistentSettingLogtraceEnable();
+
+  // Sets a persistent setting that determines whether or not
+  // events emitted by logEvent() are saved in Cobalt buffer.
+  void setPersistentSettingLogtraceEnable(boolean enable_logtrace);
+
   // Appends a string event to a ring buffer. These log events can be appended
   // from JS code. When watchdog violation is created, a snapshot of
   // that buffer is attached to a violation. Identical sequential events