Address comments

youtube · Dec 1, 2023 · 5a99d6b · 5a99d6b
1 parent 23bfcda
commit 5a99d6b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/cobalt/dom/html_element_style_test.cc b/cobalt/dom/html_element_style_test.cc
@@ -39,7 +39,7 @@ std::string GetStyleName(::testing::TestParamInfo<const char*> info) {
   return std::string(info.param);
 }
 
-std::string CamelCaseToSnakeCase(const char* camel_case) {
+std::string CamelCaseToPropertyName(const char* camel_case) {
   std::string snake;
   for (const char* input = camel_case; *input; ++input) {
     if (*input >= 'A' && *input <= 'Z') {
@@ -151,7 +151,7 @@ class HTMLElementStyleTestLongHandStyles
 
 TEST_P(HTMLElementStyleTestLongHandStyles, SetStyle) {
   const char* style_attribute_name = GetParam();
-  std::string property_name = CamelCaseToSnakeCase(style_attribute_name);
+  std::string property_name = CamelCaseToPropertyName(style_attribute_name);
   std::string script = base::StringPrintf(
       R"(
     var style_name = '%s';
@@ -190,7 +190,7 @@ class HTMLElementStyleTestShortHandStyles
 
 TEST_P(HTMLElementStyleTestShortHandStyles, SetStyle) {
   const char* style_attribute_name = GetParam();
-  std::string property_name = CamelCaseToSnakeCase(style_attribute_name);
+  std::string property_name = CamelCaseToPropertyName(style_attribute_name);
   std::string script = base::StringPrintf(
       R"(
     var style_name = '%s';

diff --git a/cobalt/persistent_storage/persistent_settings.cc b/cobalt/persistent_storage/persistent_settings.cc
@@ -48,8 +48,7 @@ PersistentSettings::PersistentSettings(const std::string& file_name)
                   kSbFileMaxPath);
   persistent_settings_file_ =
       std::string(storage_dir.data()) + kSbFileSepString + file_name;
-  // LOG(INFO) << "Persistent settings file path: " <<
-  // persistent_settings_file_;
+  LOG(INFO) << "Persistent settings file path: " << persistent_settings_file_;
 
   message_loop()->task_runner()->PostTask(
       FROM_HERE, base::Bind(&PersistentSettings::InitializePrefStore,

diff --git a/starboard/common/file.cc b/starboard/common/file.cc
@@ -50,7 +50,7 @@ void RecordFileWriteStat(int write_file_result) {
 
 bool SbFileDeleteRecursive(const char* path, bool preserve_root) {
   if (!SbFileExists(path)) {
-    // SB_LOG(ERROR) << "Path does not exist: '" << path << "'";
+    SB_LOG(ERROR) << "Path does not exist: '" << path << "'";
     return false;
   }