Skip to content

Commit

Permalink
Cherry pick PR #1492: Remove obsolete comment about ClientId (#1500)
Browse files Browse the repository at this point in the history
Refer to the original PR: #1492

b/286066035

Co-authored-by: Joel Martinez <[email protected]>
  • Loading branch information
cobalt-github-releaser-bot and joeltine authored Sep 22, 2023
1 parent 07571e6 commit 2dc2d53
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cobalt/browser/metrics/cobalt_metrics_service_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ ukm::UkmService* CobaltMetricsServiceClient::GetUkmService() {

void CobaltMetricsServiceClient::SetMetricsClientId(
const std::string& client_id) {
// TODO(b/286066035): What to do with client id here?
// ClientId is unnecessary within Cobalt. We expect the web client responsible
// for uploading these to have its own concept of device/client identifiers.
}

// TODO(b/286884542): Audit all stub implementations in this class and reaffirm
Expand Down

0 comments on commit 2dc2d53

Please sign in to comment.