Skip to content

Commit

Permalink
Add error logging, only run black box tests
Browse files Browse the repository at this point in the history
  • Loading branch information
madhurajayaraman committed Oct 15, 2024
1 parent 081ddc5 commit 24302f1
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
10 changes: 5 additions & 5 deletions cobalt/black_box_tests/black_box_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,16 +183,16 @@ def LoadTests(launcher_params, test_set):
'cobalt').GetTestFilters()

if test_set in ['all', 'blackbox']:
test_targets = _TESTS_NO_SIGNAL
# test_targets = _TESTS_NO_SIGNAL

if launcher.SupportsSuspendResume():
test_targets += _TESTS_NEEDING_SYSTEM_SIGNAL
# if launcher.SupportsSuspendResume():
# test_targets += _TESTS_NEEDING_SYSTEM_SIGNAL

if launcher.SupportsDeepLink():
test_targets += _TESTS_NEEDING_DEEP_LINK

if test_set in ['all', 'wpt']:
test_targets += _WPT_TESTS
# if test_set in ['all', 'wpt']:
# test_targets += _WPT_TESTS

test_suite = unittest.TestSuite()
for test in test_targets:
Expand Down
8 changes: 4 additions & 4 deletions starboard/shared/starboard/link_receiver.cc
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ int CreateServerSocket(SbSocketAddressType address_type) {
int on = 1;
if (setsockopt(socket_fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) != 0) {
SB_LOG(ERROR) << __FUNCTION__ << ": "
<< "SbSocketSetReuseAddress failed";
<< "Socket set reuse address failed, errno : " << errno;
return -1;
}
SB_DLOG(INFO) << "Successfully created server socket with fd : " << socket_fd;
Expand All @@ -87,7 +87,7 @@ int CreateLocallyBoundSocket(SbSocketAddressType address_type, int port) {
getsockname(socket, reinterpret_cast<sockaddr*>(&addr_in), &socklen);

if (local_add_result < 0) {
SB_LOG(ERROR) << "GetLocalhostAddress failed";
SB_LOG(ERROR) << "Get local address failed, errno : " << errno;
return -1;
}

Expand All @@ -96,7 +96,7 @@ int CreateLocallyBoundSocket(SbSocketAddressType address_type, int port) {

if (bind_result != 0) {
SB_LOG(ERROR) << __FUNCTION__ << ": "
<< "SbSocketBind to " << port << " failed: " << bind_result;
<< "Socket bind to " << port << " failed, errno : " << errno;
return -1;
}

Expand All @@ -114,7 +114,7 @@ int CreateListeningSocket(SbSocketAddressType address_type, int port) {
int listen_result = listen(socket, kMaxConn);
if (listen_result != 0) {
SB_LOG(ERROR) << __FUNCTION__ << ": "
<< "SbSocketListen failed: " << listen_result;
<< "Socket listen failed, errno : " << errno;
return -1;
}

Expand Down

0 comments on commit 24302f1

Please sign in to comment.