Skip to content

Commit

Permalink
Refine toolchain selection condition
Browse files Browse the repository at this point in the history
This is a rework of PR #3185.

b/330771976
  • Loading branch information
maxz-lab committed May 10, 2024
1 parent 79adf53 commit 152c3c2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 4 additions & 1 deletion starboard/elf_loader/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,12 @@ static_library("elf_loader") {
":evergreen_info",
"//starboard:starboard_group",
"//starboard/common",
"//starboard/shared/modular:starboard_layer_posix_abi_wrappers",
"//third_party/lz4_lib:lz4",
]

if (current_toolchain == starboard_toolchain) {
deps += [ "//starboard/shared/modular:starboard_layer_posix_abi_wrappers" ]
}
}

if (sb_is_evergreen_compatible && current_toolchain == starboard_toolchain) {
Expand Down
3 changes: 1 addition & 2 deletions starboard/shared/modular/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
# TODO: b/315170518 - Revert to static library after fixing
# symbol visibility issues for windows based modular platform builds.
if ((sb_is_modular || sb_is_evergreen_compatible) &&
(current_toolchain == starboard_toolchain ||
build_with_separate_cobalt_toolchain)) {
current_toolchain == starboard_toolchain) {
source_set("starboard_layer_posix_abi_wrappers") {
sources = [
"starboard_layer_posix_mmap_abi_wrappers.cc",
Expand Down

0 comments on commit 152c3c2

Please sign in to comment.