add emptyCheckInterval option to improve performance #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where a replicaset doesn't have any docs matching the target namespaces (which happens with tag aware sharding), we don't want to keep generating (empty) oplog cursors on that replica set. This option uses a cheaper `db.collection.count()` call to see if a replica set has any matching docs and waits a configurable amount of time before checking again.
|
I've restarted the travis build because it seems it failed for unrelated reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where a replicaset doesn't have any docs matching the
target namespaces (which happens with tag aware sharding), we don't
want to keep generating (empty) oplog cursors on that replica set.
This option uses a cheaper
db.collection.count()call to see ifa replica set has any matching docs and waits a configurable amount
of time before checking again.