fix: change command execution to start instead of output #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for superfile canceled.
|
|
Thank you so much, this is a great update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue mentioned in: #364
Issue
The program was freezing when attempting to launch an application using the exec.Command function. This was due to the use of cmd.Output(), which waits for the command to complete and captures its output. If the launched application does not terminate, the program would hang indefinitely.
Solution
To resolve this issue, the code was modified to use cmd.Start() instead of cmd.Output(). The cmd.Start() function starts the specified command but does not wait for it to complete, allowing the program to continue running without freezing.