Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Emergency Shuttle: The Fleet #22615

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

CrazyDrakkon
Copy link

@CrazyDrakkon CrazyDrakkon commented Sep 19, 2024

Document the changes in your pull request

(My first PR) Adds massive new "shuttle"/collection of shuttles, each representing a department, that are connected via quantum pads. Includes a brig and medical shuttle.

image

Why is this good for the game?

Adds a fun, high-end shuttle option. Alternative to the Luxury Shuttle that isn't ugly.

Testing

Tested. It fits.

image

image

Changelog

🆑

rscadd: Added new emergency shuttle: The Fleet

/:cl:

@CrazyDrakkon CrazyDrakkon requested a review from a team as a code owner September 19, 2024 20:31
@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Sep 19, 2024
@Scrambledeggs00
Copy link
Contributor

You forgot to make a ship for the based department
absolutecinema

@github-actions github-actions bot added the Mapping Will result in a change to a map. label Sep 19, 2024
@AMyriad
Copy link
Contributor

AMyriad commented Sep 19, 2024

do it...dock?

image

@CrazyDrakkon
Copy link
Author

do it...dock?

image

Measured it so that it's right on the edge of the area that makes you travel to the next z-level. (Atleast on Box 💀)

@ToasterBiome
Copy link
Contributor

This sucks

Upvote

accessible without access => publicly accessible
Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is a mess I love it
On a more serious note, before I take a closer look, can you show proof of testing of this thing docking at the station and at centcom?

Made actually functional portals and minor changes, updated description accordingly.
@CrazyDrakkon
Copy link
Author

Agreed this is a mess I love it On a more serious note, before I take a closer look, can you show proof of testing of this thing docking at the station and at centcom?

Yup, it fits 👍

@ToasterBiome ToasterBiome added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label Oct 2, 2024
Copy link
Contributor

@AMyriad AMyriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, so this is a pretty funny idea and I respect the effort you put into this, but I don't see it working as it is now. Balance concerns aside (there is a lot of space to run/hide in), the main problem is this thing is just too BIG.

I did some size estimates to check, and sadly yes this shuttle is too chonky to fit in a number of places, such as the syndicate hijack base and donutstation for example. I'm sure it fits on boxstation and centcom fine, but mind you those aren't the only maps in existence.

And since this'd be probably the biggest shuttle design we'd be adding, whatever maps we make from now on would have to abide by its size, meaning we'd be forced to keep the evac docks absolutely clear of anything in a large radius just so this beast could fit.

image
image

@CrazyDrakkon
Copy link
Author

CrazyDrakkon commented Oct 2, 2024

I did some size estimates to check, and sadly yes this shuttle is too chonky to fit in a number of places, such as the syndicate hijack base and donutstation for example. I'm sure it fits on boxstation and centcom fine, but mind you those aren't the only maps in existence.

And since this'd be probably the biggest shuttle design we'd be adding, whatever maps we make from now on would have to abide by its size, meaning we'd be forced to keep the evac docks absolutely clear of anything in a large radius just so this beast could fit.

Large shuttles (emergency_meteor.dmm (40x40) and emergency_pubby.dmm (8x46) dock with other stations and can get hijacked, and this one is 37x47. When docking, they just "crash" into and remove what structures are in the way. The hyperspace adjusts to the size in transit.

Testing (It just freaked out from being rotated):

Donut:

image

image

Hijacked:

image

image

@neeshacark
Copy link
Contributor

It crashing into the grilles of donut's shipbreaking isn't the biggest deal explicitly because if i ever get off my lazy ass (the time grows near) donut is getting replaced with a smaller, worser version

as for the syndibase would you lookie at that

@JamieD1
Copy link
Contributor

JamieD1 commented Oct 28, 2024

I dislike some of the 1by1 sections, this reduces good combat and antics.

@CrazyDrakkon
Copy link
Author

I dislike some of the 1by1 sections, this reduces good combat and antics.

Does this sufficiently fix?

image

Removes closed 1x1 areas from pods
@JamieD1
Copy link
Contributor

JamieD1 commented Nov 10, 2024

I dislike some of the 1by1 sections, this reduces good combat and antics.

Does this sufficiently fix?

image

You can put it back, I meant on most of the shuttles but, its not a game changer, will wait to hear from @yogstation13/map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer Feature This adds new content to the game Mapping Will result in a change to a map.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants