use string for package version comparison

yjunechoe · Jul 18, 2023 · 1aacdb2 · 1aacdb2
1 parent ac6e76d
commit 1aacdb2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # jlmerclusterperm (development version)
 
+Fixes for CRAN:
+
+- Use string for package version comparison
 
 # jlmerclusterperm 1.0.2
 

diff --git a/R/aaa.R b/R/aaa.R
@@ -14,7 +14,7 @@
 # Helpers
 julia_version_compatible <- function() {
   julia_version <- gsub("^.*(\\d+\\.\\d+\\.\\d+).*$", "\\1", system2("julia", "--version", stdout = TRUE))
-  as.package_version(julia_version) >= 1.8
+  as.package_version(julia_version) >= "1.8"
 }
 is_setup <- function() isTRUE(.jlmerclusterperm$is_setup)
 

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,8 +1,4 @@
-* Small patch to fix a failure to parse the Julia version when it's in rc or alpha.
-
-* The exclusion of Manifest.toml is now specified in .Rbuildignore - only Project.toml is bundled as intended. Users will generate their own Manifest.toml as part of activating the project. This resolves the errors from a prior submission where the accidental inclusion of my own Manifest.toml triggered a stricter criteria for resolving the versions of (downstream) dependencies.
-
-Apologies for frequency of resubmission.
+* Small patch to use string for package version comparison
 
 ## R CMD check results