feat: batcher should not be able to build batches too big #1410
+142
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batcher max_batch_len limit
Description
This PR adds a feature on the Batcher that prevents it from making batches too big, that would revert in ETH due to gas cost limitations.
Type of change
Checklist
testnet
, everything else tostaging
To Test
You can play around with this new
max_batch_len
variable, set inconfig-batcher.yaml
.For example, set it at 16, then send a burst of 20.
You should see the batcher correctly sending one batch of 16 and another of 4.