Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batcher): adjust MAX_DELAY to one hour #1405

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

avilagaston9
Copy link
Collaborator

@avilagaston9 avilagaston9 commented Nov 12, 2024

Adjust MAX_DELAY to one hour

Motivation

In our retry_functionin the batcher were using the default MAX_DELAY which was only 60 secs.

Description

  • Sets the MAX_DELAY of our retry_function to be 1 hour.
  • Changes CANCEL_TRANSACTION_MAX_RETRIES to 33 (one day).
  • Adds docs to the functions that uses the retry_function.
  • Changes TransactionSendError (while waiting for the transaction receipt in create_new_task) to be permanent since we have no way to recover from that.

Type of change

  • Bug fix

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@avilagaston9 avilagaston9 marked this pull request as ready for review November 12, 2024 20:56
@avilagaston9 avilagaston9 added the batcher issues within aligned-batcher label Nov 12, 2024
@avilagaston9 avilagaston9 self-assigned this Nov 12, 2024
@MauroToscano MauroToscano added this pull request to the merge queue Nov 13, 2024
Merged via the queue into staging with commit 2c45fb2 Nov 13, 2024
3 checks passed
@MauroToscano MauroToscano deleted the adjust-batcher-retries-parameters branch November 13, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batcher issues within aligned-batcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants