-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update sp1 and risc0 #1307
update sp1 and risc0 #1307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me!
Makefile
Outdated
@@ -17,7 +17,7 @@ ifeq ($(OS),Darwin) | |||
endif | |||
|
|||
ifeq ($(OS),Linux) | |||
LD_LIBRARY_PATH += $(CURDIR)/operator/risc_zero/lib | |||
export LD_LIBRARY_PATH+=$(CURDIR)/operator/risc_zero_old/lib:$(CURDIR)/operator/risc_zero/lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not have the export
keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? Isn't the point to have this on the environment for child processes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we had a bug related to this previosly which was solved in #1299. Maybe the problem was another?
lib/librisc_zero_verifier_ffi.so | ||
lib/librisc_zero_verifier.dylib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
were these changes necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the _ffi
suffix initially as I found it redundant. When compiling on linux the linker was unable to find the shared library for risc0 without having the _ffi
suffix added which leads to the difference in naming between the .so
and .dylib
. I was not sure why we initially were ignoring the .a
file so I changed to ignoring the .so
. I don't have a strong opinion on the naming for the macos shared library.
I believe there might be missing steps in the testing procedure:
|
@Oppen apologies corrected the example commands in the description above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Close
docs/3_guides/6_setup_aligned.md
Outdated
@@ -493,7 +493,7 @@ make install_aligned_compiling | |||
|
|||
The SP1 and Risc0 proofs need the proof file and the vm program file. | |||
The current SP1 version used in Aligned is | |||
`v1.0.1` and the current Risc0 version used in Aligned is v1.0.1. | |||
`v2.0.0` and the current Risc0 version used in Aligned is `v1.1.2`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it v3.0.0-rc3 instead of v2.0.0
Update SP1 and Risc0 verifier versions
closes #1205
This PR:
risc0
andsp1
verifier versions of operators.dialoguer
->inquire
to accomodate a dependency conflict.To Test:
Verify network bindings works on a local network:
make test_risc_zero_go_bindings_macos
make test_sp1_go_bindings_macos
make batcher_send_risc0_task
make batcher_send_sp1_task
cd examples/zkquiz && make answer_quix
cd examples/validating-public-input && make generate_risc_zero_fibonacci_proof
Verify Retro Compatiblility of Operator Verifiers:
To verify operator retro-compatibility we deploy the rest of infrastructure of Aligned and boot the retro-compatible operator. This tests that network retro-compatible operator can verify SP1/Risc0 proofs from both verifier versions.
Note:
Commands suffixed with
_old
indicate the deprecated version of the SP1/Risc0 verifier that is currently running ontestnet
To test this have two repos of aligned_layer one set to
testnet
and one to1205-bump-sp1-and-risc0-version
.In
testnet
repo:In
1205-bump-sp1-and-risc0-version
repo:testnet
repo.Observe the
Risc0 proof verification failed.
andSP1 proof verification failed.
logs are emitted and the operator successfully verifying the proofs from the old SP1/Risc0 verifiers. If you send a proof from the latest version of SP1/Risc0 you should notice its verification fails in the batcher.1205-bump-sp1-and-risc0-version
repo.testnet
repo, kill the batcher.1205-bump-sp1-and-risc0-version
and start the batcher within the repo.1205-bump-sp1-and-risc0-version
repo.Observe the operator successfully verifying the proofs from the new SP1/Risc0 verifiers. If you send a proof from the older version of SP1/Risc0 you should notice its verification fails in the batcher.
Type of change
Please delete options that are not relevant.
Checklist