Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: batcherPaymentService pause individual functions #1272

Draft
wants to merge 42 commits into
base: staging
Choose a base branch
from
Draft

feat: batcherPaymentService pause individual functions #1272

wants to merge 42 commits into from

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Oct 16, 2024 •
edited
Loading

This PR has only the very beggining of solving the issue.
It was an initial commit so as to enable the PR creation, but it still needs developing and testing

  • migrating to the new pausbale
  • migrating the deployer/upgrader if necesarry
  • testing if the upgrade from the previous version looses storage (it is probable, since the batcher will change some storage due to the new inheritance)

JuArce and others added 30 commits June 24, 2024 18:35
@JuArce
chore: implement pausable in ServiceManager
fd7b01f
@JuArce
chore: add upgrade script to add Pausable to ServiceManager
4ba4904
@JuArce
fix: rename upgrade target
965371b
@JuArce
Merge branch 'main' into 480-chore-implement-pausable-in-servicemanager
63aa33c
@JuArce
fix: add new lines
6a56d87
@JuArce
Merge remote-tracking branch 'origin/480-chore-implement-pausable-in-…
82b5075 
…servicemanager' into 480-chore-implement-pausable-in-servicemanager
@JuArce
chore: add comments
8a534b2
@entropidelic
Merge branch 'main' into 480-chore-implement-pausable-in-servicemanager
c3cdc78
@entropidelic
fix typo
52f45e3
@entropidelic
Merge branch 'main' into 480-chore-implement-pausable-in-servicemanager
91fc625
@JuArce
fix(contracts): registrycoordinator pauser is set to eigenlayer addre…
242df3b 
…sses (#501)
@JuArce
Merge branch 'refs/heads/main' into 480-chore-implement-pausable-in-s…
57c32b2 
…ervicemanager

# Conflicts:
#	contracts/scripts/anvil/state/alignedlayer-deployed-anvil-state.json
#	contracts/src/core/AlignedLayerServiceManager.sol
@JuArce
fix: upgrader
4976e0b
@JuArce
Merge branch 'refs/heads/main' into 480-chore-implement-pausable-in-s…
c78db1c 
…ervicemanager

# Conflicts:
#	contracts/script/output/devnet/alignedlayer_deployment_output.json
@JuArce
fix: deploy contracts
9d03b18
@uri-99
Merge branch 'staging' into 480-chore-implement-pausable-in-servicema…
6c0cc70 
…nager
@uri-99
fix: simple compile bugs
6275409
@uri-99
fix: imports in aligned.sol
921aed2
@uri-99
fix: upgrade to pausable onchain
f369b1e
@uri-99
fix: make target
00c7535
@uri-99
chore: remove comments
8c26d54
@uri-99
fix: output of pauser registry
61cfd7f
@uri-99
feat: add pausable to verifyInitalizations
df0f069
@uri-99
feat: pause and unpause make targets
b262d58
@uri-99
Merge remote-tracking branch 'origin/staging' into 480-chore-implemen…
06067f6 
…t-pausable-in-servicemanager
@uri-99
chore: remove comment
9c4995e
@uri-99
fix: change hardcoded address values
08d3982
@uri-99
fix: update hardcoded alignedLayerServiceManager address in config ba…
5e067bb 
…tcher
@uri-99
feat: batcher pauser make targets
5d16357
@uri-99
feat: update which functions are pausable
e10a80d
@github-actions GitHub Actions
Copy link

Changes to gas cost

Generated at commit: 87c4d5857c57309ecd3b95565a6aabdc1e856442, compared to commit: b94224dfa0c842923430c2bd99dfedf0d9abb659

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
AlignedLayerServiceManager createNewTask -181 ✅ -0.24%
Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
AlignedLayerServiceManager 5,254,372 (0) createNewTask
receive		 55,975 (-543)
23,318 (0)		 -0.96%
0.00%		 75,888 (-181)
46,828 (-187)		 -0.24%
-0.40%		 76,133 (-54)
47,202 (0)		 -0.07%
0.00%		 76,937 (+75)
47,202 (0)		 +0.10%
0.00%		 256 (0)
256 (0)

@uri-99 uri-99 mentioned this pull request Oct 16, 2024
Merged
Base automatically changed from 480-chore-implement-pausable-in-servicemanager to staging November 6, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uri-99 @JuArce @entropidelic