feat: WIP on amountFormat #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 10, 2023
karelianpie
reviewed
Jul 11, 2023
karelianpie
approved these changes
Jul 12, 2023
karelianpie
previously approved these changes
Jul 12, 2023
Co-authored-by: Chef Karelian <[email protected]>
Co-authored-by: Chef Karelian <[email protected]>
Co-authored-by: Chef Karelian <[email protected]>
Co-authored-by: Chef Karelian <[email protected]>
Co-authored-by: Chef Karelian <[email protected]>
Co-authored-by: Chef Karelian <[email protected]>
Majorfi
force-pushed
the
feat/amountFormat
branch
from
4818a28
to
d8d2e11
Compare
Majorfi
added a commit
that referenced
this pull request
Jul 14, 2023
* feat: WIP on amountFormat * fix: design * feat: update vault list with number formatter * feat: add tests * Update apps/common/utils/format.test.ts Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.test.ts Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * feat: merge recs * refactor: Extract formatter to web-lib * fix: move file out of utils * feat: update number display * feat: Add shouldShowTooltip prop * refactor: Show tooltip only for small numbers * refactor: Remove unnecessary prop * fix: new type err * fix: disable withTM in prod * feat: bump weblib * fix: bump pkg --------- Co-authored-by: Chef Karelian <[email protected]> Co-authored-by: Karelian Pie <[email protected]>
Majorfi
added a commit
that referenced
this pull request
Jul 15, 2023
* feat: Add 'Boosted' category to Opti vaults * fix: add more staking rewards * fix: rename * feat: WIP on amountFormat (#270) * feat: WIP on amountFormat * fix: design * feat: update vault list with number formatter * feat: add tests * Update apps/common/utils/format.test.ts Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.test.ts Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * Update apps/common/utils/format.tsx Co-authored-by: Chef Karelian <[email protected]> * feat: merge recs * refactor: Extract formatter to web-lib * fix: move file out of utils * feat: update number display * feat: Add shouldShowTooltip prop * refactor: Show tooltip only for small numbers * refactor: Remove unnecessary prop * fix: new type err * fix: disable withTM in prod * feat: bump weblib * fix: bump pkg --------- Co-authored-by: Chef Karelian <[email protected]> Co-authored-by: Karelian Pie <[email protected]> * feat: add new withRewards --------- Co-authored-by: Major <[email protected]> Co-authored-by: Major <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP implementation of a refactor on the amount display to get rid of the troubles of format format format format format format, have a react component to avoid having to set the suppress hydratation warning and display an information tooltip, handle edge case (big value, dust amount) and symbol displaying
Related Issue
NA
Motivation and Context
See description
How Has This Been Tested?
Locally tested on the vault list page on Ethereum, still some work to do
Screenshots (if appropriate):