Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table-cache: remove getFirstLevelCache from table #59

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lavrukov
Copy link
Contributor

@lavrukov lavrukov commented Apr 8, 2024

No description provided.

@lavrukov lavrukov requested review from akorsukov and nvamelichev and removed request for akorsukov April 8, 2024 07:52
@nvamelichev
Copy link
Collaborator

nvamelichev commented Apr 10, 2024

  • Checkstyle error
/home/runner/work/yoj-project/yoj-project/repository/src/main/java/tech/ydb/yoj/repository/db/TableUtils.java:20:20: Use a single space to separate non-whitespace characters. [SingleSpaceSeparator]
  • TableUtils class: I have some minor suggestions
    • functionality: Currently this class feels like an orphan. We probably should move some common functionality from InMemoryTable/YdbTable there (e.g. working with first-level cache and projection cache for basic entity find(ID), save/insert(ID), delete(ID)). We can do this in a separate PR, or course.
    • naming: YOJ generally does not use the XxxUtils convention (except for some classes like YqlUtils that were ultimately deleted). Maybe [Common]TableQueries or something like this (Guava-style, in plural)?
    • @UtilityClass Lombok annotation is non-intuitive: it makes instance methods static, I think we shouldn't use it. Making the class final and adding an empty private constructor does not take a lot of boilerplate. (And YOJ was migrated from @UtilityClass when open-sourcing it).

Copy link
Collaborator

@nvamelichev nvamelichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants