Merge pull request #39 from elabpro/FIX-VERSION

Fix version info in build

Dockerfile

@@ -1,4 +1,5 @@
 FROM golang:1.22 as builder
+ARG APP_VERSION=no-APP_VERSION-supplied-in-buildtime
 RUN mkdir /app
 WORKDIR /app
 COPY . /app

Makefile

@@ -25,16 +25,16 @@ build-macos: lint pre-build
 
 build: lint pre-build
 	CGO_ENABLED=0 GOARCH=amd64 GOOS=linux go build -ldflags=${LDFLAGS} -o ${BUILD_DIR}/${BINARY_NAME} main.go
-	strip bin/${BINARY_NAME}
+	strip ${BUILD_DIR}/${BINARY_NAME}
 
 clear:
-	rm -rf bin/${BINARY_NAME}
+	rm -rf ${BUILD_DIR}/${BINARY_NAME}
 
 dep:
 	go mod download
 
 docker:
-	docker build --force-rm -t $(BINARY_NAME) .
+	docker build --force-rm -t $(BINARY_NAME) --build-arg APP_VERSION=${APP_VERSION} .
 
 test:
 	if [ "$(shell uname)" = "Linux" ]; then make build; else make build-macos; fi

README.md

@@ -80,11 +80,11 @@ ginkgo test -vvv ./tests
 ### How to develop
 
 - develop a feature
-- invoke `changie new` and complete a small interactive form
-- don't forget to changie-generated file to your PR
+- invoke `changie new` and complete a small interactive form. (Get changie from https://changie.dev )
+- don't forget to changie-generated file to your PR into master branch
 
 ### How to release a new version
 
-1. Invoke `create-release-pr` job, it will create a PR with `CHANGELOG.md` containing all diffs 
+1. Invoke Github action `create-release-pr` job, it will create a PR with `CHANGELOG.md` containing all diffs 
 2. After making sure that `CHANGELOG.md` looks nice, just merge the PR from step 1, and the commit into master
    will be automatically tagged, and a new release with new binaries will be automatically published!