-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add LastSuccessfulBackupId retrieval on listing schedules #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrort
force-pushed
the
schedule-daemon
branch
2 times, most recently
from
September 17, 2024 13:50
a338bc7
to
ddc4bc0
Compare
qrort
force-pushed
the
tb-with-schedule-id
branch
from
September 19, 2024 12:21
baba2c9
to
d80ebb2
Compare
qrort
force-pushed
the
schedule-daemon
branch
from
September 19, 2024 12:22
ddc4bc0
to
08cc852
Compare
qrort
changed the title
add schedule support to TakeBackup handler
add LastSuccessfulBackupId retrieval on listing schedules
Sep 19, 2024
qrort
force-pushed
the
tb-with-schedule-id
branch
from
September 19, 2024 12:27
d80ebb2
to
f02169c
Compare
qrort
force-pushed
the
schedule-daemon
branch
5 times, most recently
from
September 20, 2024 13:13
b1b86b2
to
9ac72ee
Compare
qrort
force-pushed
the
tb-with-schedule-id
branch
from
September 23, 2024 11:43
f02169c
to
4a63e37
Compare
qrort
force-pushed
the
tb-with-schedule-id
branch
2 times, most recently
from
September 23, 2024 11:52
4e128f0
to
bb0cde5
Compare
📝 Test results33 tests (33 passed)
|
📦 Package | 🟢 Passed | 🔴 Failed | 🟡 Skipped | ⏳ Duration |
---|---|---|---|---|
🟡 ydbcp/cmd/integration | 0 | 0 | 0 | 1ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/cmd/ydbcp | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/auth | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟢 ydbcp/internal/backup_operations | 2 | 0 | 0 | 1036ms |
🧪 Tests
🖨️ Output
| ||||
🟡 ydbcp/internal/config | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/connectors/client | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/connectors/db | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟢 ydbcp/internal/connectors/db/yql/queries | 5 | 0 | 0 | 1020ms |
🧪 Tests
🖨️ Output
| ||||
🟡 ydbcp/internal/connectors/s3 | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟢 ydbcp/internal/handlers | 24 | 0 | 0 | 1038ms |
🧪 Tests
🖨️ Output
| ||||
🟢 ydbcp/internal/processor | 2 | 0 | 0 | 1022.9999999999999ms |
🧪 Tests
🖨️ Output
| ||||
🟡 ydbcp/internal/server | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/grpcinfo | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/services/backup | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/services/backup_schedule | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/services/operation | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/types | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/util/ticker | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/util/timer | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/util/xlog | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/pkg/plugins/auth | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/pkg/proto/ydbcp/v1alpha1 | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/plugins/auth_nebius | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/plugins/auth_nebius/proto/iam/v1 | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
|
qrort
force-pushed
the
tb-with-schedule-id
branch
from
September 23, 2024 11:58
bb0cde5
to
6f65795
Compare
📝 Test results33 tests (33 passed)
|
📦 Package | 🟢 Passed | 🔴 Failed | 🟡 Skipped | ⏳ Duration |
---|---|---|---|---|
🟡 ydbcp/cmd/integration | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/cmd/ydbcp | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/auth | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟢 ydbcp/internal/backup_operations | 2 | 0 | 0 | 0ms |
🧪 Tests
🖨️ Output
| ||||
🟡 ydbcp/internal/config | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/connectors/client | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/connectors/db | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟢 ydbcp/internal/connectors/db/yql/queries | 5 | 0 | 0 | 0ms |
🧪 Tests
🖨️ Output
| ||||
🟡 ydbcp/internal/connectors/s3 | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟢 ydbcp/internal/handlers | 24 | 0 | 0 | 1ms |
🧪 Tests
🖨️ Output
| ||||
🟢 ydbcp/internal/processor | 2 | 0 | 0 | 0ms |
🧪 Tests
🖨️ Output
| ||||
🟡 ydbcp/internal/server | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/grpcinfo | 0 | 0 | 0 | 1ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/services/backup | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/services/backup_schedule | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/server/services/operation | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/types | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/util/ticker | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/util/timer | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/internal/util/xlog | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/pkg/plugins/auth | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/pkg/proto/ydbcp/v1alpha1 | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/plugins/auth_nebius | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
| ||||
🟡 ydbcp/plugins/auth_nebius/proto/iam/v1 | 0 | 0 | 0 | 0ms |
🧪 Tests(none)🖨️ Output
|
qrort
force-pushed
the
tb-with-schedule-id
branch
2 times, most recently
from
September 23, 2024 18:10
a4c0ba9
to
6f360c0
Compare
qrort
force-pushed
the
tb-with-schedule-id
branch
from
September 23, 2024 18:13
6f360c0
to
217cd0e
Compare
bma13
reviewed
Sep 24, 2024
internal/server/services/backup_schedule/backup_schedule_service.go
Outdated
Show resolved
Hide resolved
internal/server/services/backup_schedule/backup_schedule_service.go
Outdated
Show resolved
Hide resolved
bma13
approved these changes
Sep 24, 2024
Co-authored-by: Mikhail Babich <[email protected]>
Co-authored-by: Mikhail Babich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.