Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dataraces in PDisk and add VERIFY to prevent out-of-bounds access #9818

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

va-kuznecov
Copy link
Member

Changelog entry

...

Changelog category

  • Bugfix

Additional information

...

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 15:31:17 UTC Pre-commit check linux-x86_64-release-asan for b049944 has started.
2024-09-26 15:31:27 UTC Artifacts will be uploaded here
2024-09-26 15:34:17 UTC ya make is running...
🟡 2024-09-26 17:53:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11027 10807 0 52 45 123

🟢 2024-09-26 17:54:33 UTC Build successful.
🟢 2024-09-26 17:55:09 UTC ydbd size 5.7 GiB changed* by +3.3 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7d208c7 merge: b049944 diff diff %
ydbd size 6 084 945 760 Bytes 6 084 949 176 Bytes +3.3 KiB +0.000%
ydbd stripped size 1 520 889 744 Bytes 1 520 890 832 Bytes +1.1 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 26, 2024

2024-09-26 15:31:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for b049944 has started.
2024-09-26 15:31:28 UTC Artifacts will be uploaded here
2024-09-26 15:34:28 UTC ya make is running...
🟡 2024-09-26 17:17:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15682 14018 0 9 1615 40

2024-09-26 17:19:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-26 17:30:35 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
292 (only retried tests) 194 0 2 7 89

2024-09-26 17:30:44 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-26 17:42:03 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
96 (only retried tests) 7 0 0 0 89

🟢 2024-09-26 17:42:11 UTC Build successful.
🟢 2024-09-26 17:42:56 UTC ydbd size 8.5 GiB changed* by +4.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 7d208c7 merge: b049944 diff diff %
ydbd size 9 081 561 320 Bytes 9 081 565 480 Bytes +4.1 KiB +0.000%
ydbd stripped size 490 872 840 Bytes 490 873 224 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@va-kuznecov va-kuznecov changed the title Fixed dataraces in PDisk and add VERIFY to prevent out-of-bounds access Fixe dataraces in PDisk and add VERIFY to prevent out-of-bounds access Sep 26, 2024
@va-kuznecov va-kuznecov changed the title Fixe dataraces in PDisk and add VERIFY to prevent out-of-bounds access Fix dataraces in PDisk and add VERIFY to prevent out-of-bounds access Sep 26, 2024
@github-actions github-actions bot added bugfix and removed bugfix labels Sep 26, 2024
@va-kuznecov va-kuznecov merged commit 10f5f54 into ydb-platform:main Sep 27, 2024
12 of 13 checks passed
@va-kuznecov va-kuznecov deleted the dev/fix_pdisk_dataraces branch September 27, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants