Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error messages and comments for unsupported operations #136

Merged
merged 1 commit into from
Jul 20, 2024
Merged

Update error messages and comments for unsupported operations #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hibernate-dialect-v5/src/main/java/tech/ydb/hibernate/dialect/YdbDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ public String getCurrentTimestampSelectString() {

@Override
public String getForUpdateString() {
throw new UnsupportedOperationException("YDB don't support FOR UPDATE statement");
throw new UnsupportedOperationException("YDB does not support FOR UPDATE statement");
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion hibernate-dialect/src/main/java/tech/ydb/hibernate/dialect/YdbDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ public String getCurrentTimestampSelectString() {

@Override
public String getForUpdateString() {
throw new UnsupportedOperationException("YDB don't support FOR UPDATE statement");
throw new UnsupportedOperationException("YDB does not support FOR UPDATE statement");
}

@Override
Expand Down
6 changes: 3 additions & 3 deletions liquibase-dialect/src/main/java/tech/ydb/liquibase/database/YdbDatabase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,23 +119,23 @@ public boolean supportsTablespaces() {
}

/**
* YDB don't support foreign key
* YDB does not support foreign key
*/
@Override
public boolean supportsForeignKeyDisable() {
return true;
}

/**
* YDB don't support sequences
* YDB does not support sequences (yet)
*/
@Override
public boolean supportsSequences() {
return false;
}

/**
* YDB don't support auto increment
* YDB does not support auto increment (yet)
*/
@Override
public boolean supportsAutoIncrement() {
Expand Down
4 changes: 2 additions & 2 deletions spring-data-dialect/src/main/java/tech/ydb/data/core/dialect/YdbDialect.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public Position getClausePosition() {

private static final LockClause LOCK_CLAUSE = new LockClause() {
public String getLock(LockOptions lockOptions) {
throw new UnsupportedOperationException("YDB don't support pessimistic locks");
throw new UnsupportedOperationException("YDB does not support pessimistic locks");
}

public LockClause.Position getClausePosition() {
Expand Down Expand Up @@ -76,7 +76,7 @@ public Set<Class<?>> simpleTypes() {
@Override
public InsertRenderContext getInsertRenderContext() {
return () -> {
throw new UnsupportedOperationException("YDB don't support VALUES (DEFAULT) statement");
throw new UnsupportedOperationException("YDB does not support VALUES (DEFAULT) statement");
};
}

Expand Down
Loading