Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Renamed {retry,table}.WithID option to {retry,table}.WithLabel #875

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Oct 24, 2023
@asmyasnikov asmyasnikov marked this pull request as ready for review October 24, 2023 00:08
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

github.com/ydb-platform/ydb-go-sdk/v3/retry

incompatible changes

WithID: removed

compatible changes

WithLabel: added

github.com/ydb-platform/ydb-go-sdk/v3/table

incompatible changes

Options.ID: removed
WithID: removed

compatible changes

Options.Label: added
WithLabel: added

github.com/ydb-platform/ydb-go-sdk/v3/trace

incompatible changes

RetryOnRetry: changed from func(*Retry, *context.Context, string, bool, bool) func(error) func(attempts int, _ error) to func(*Retry, *context.Context, string, string, bool, bool) func(error) func(attempts int, _ error)
TableOnDo: changed from func(*Table, *context.Context, string, bool, bool) func(error) func(attempts int, _ error) to func(*Table, *context.Context, string, string, bool, bool) func(error) func(attempts int, _ error)
TableOnDoTx: changed from func(*Table, *context.Context, string, bool, bool) func(error) func(attempts int, _ error) to func(*Table, *context.Context, string, string, bool, bool) func(error) func(attempts int, _ error)

compatible changes

RetryLoopStartInfo.Label: added
TableDoStartInfo.Label: added
TableDoTxStartInfo.Label: added

summary

Base version: v3.53.5-0.20231023235613-43bf888c0ac3 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.53.4.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (43bf888) 66.79% compared to head (7f56a00) 66.81%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #875      +/-   ##
==========================================
+ Coverage   66.79%   66.81%   +0.02%     
==========================================
  Files         255      255              
  Lines       24138    24150      +12     
==========================================
+ Hits        16123    16136      +13     
  Misses       7179     7179              
+ Partials      836      835       -1     
Flag Coverage Δ
53.41% <91.48%> (+0.04%) ⬆️
go-1.17.x 65.40% <78.72%> (+0.03%) ⬆️
go-1.20.x 66.67% <91.48%> (-0.06%) ⬇️
go-1.21.x 66.67% <91.48%> (-0.08%) ⬇️
integration 53.41% <91.48%> (+0.04%) ⬆️
macOS 39.35% <12.76%> (-0.03%) ⬇️
ubuntu 39.34% <12.76%> (+<0.01%) ⬆️
unit 39.44% <12.76%> (-0.02%) ⬇️
windows 39.39% <12.76%> (+<0.01%) ⬆️
ydb-22.5 53.17% <91.48%> (+0.28%) ⬆️
ydb-23.1 53.08% <91.48%> (+0.06%) ⬆️
ydb-23.2 52.80% <91.48%> (-0.31%) ⬇️
ydb-23.3 53.13% <91.48%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/table/retry.go 79.13% <100.00%> (-0.36%) ⬇️
log/retry.go 95.45% <100.00%> (ø)
retry/retry.go 74.69% <100.00%> (+0.31%) ⬆️
retry/sql.go 89.10% <ø> (ø)
table/table.go 76.14% <100.00%> (ø)
log/table.go 73.76% <83.33%> (+0.17%) ⬆️
metrics/table.go 88.23% <75.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmyasnikov asmyasnikov force-pushed the with-label branch 2 times, most recently from b7964b9 to 88d2347 Compare October 24, 2023 00:53
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@asmyasnikov asmyasnikov merged commit eae4c63 into master Oct 24, 2023
48 of 49 checks passed
@asmyasnikov asmyasnikov deleted the with-label branch October 24, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants