Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TestErrorBrief #873

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix TestErrorBrief #873

merged 1 commit into from
Oct 23, 2023

Conversation

asmyasnikov
Copy link
Member

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@asmyasnikov asmyasnikov self-assigned this Oct 23, 2023
@asmyasnikov asmyasnikov marked this pull request as ready for review October 23, 2023 21:01
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6cf18a) 66.43% compared to head (821f991) 66.45%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
+ Coverage   66.43%   66.45%   +0.02%     
==========================================
  Files         254      254              
  Lines       24046    24046              
==========================================
+ Hits        15974    15980       +6     
+ Misses       7240     7231       -9     
- Partials      832      835       +3     
Flag Coverage Δ
52.97% <ø> (-0.10%) ⬇️
go-1.17.x 65.03% <ø> (+0.02%) ⬆️
go-1.20.x 66.30% <ø> (-0.07%) ⬇️
go-1.21.x 52.64% <ø> (-13.51%) ⬇️
integration 52.97% <ø> (-0.10%) ⬇️
macOS 39.46% <ø> (+0.01%) ⬆️
ubuntu 39.44% <ø> (+<0.01%) ⬆️
unit 39.48% <ø> (-0.04%) ⬇️
windows ?
ydb-22.5 52.69% <ø> (+<0.01%) ⬆️
ydb-23.1 52.62% <ø> (-0.08%) ⬇️
ydb-23.2 52.57% <ø> (-0.01%) ⬇️
ydb-23.3 52.76% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

summary

Base version: v3.53.5-0.20231023151705-e6cf18ae9ba0 (master)
Cannot suggest a release version.
Can only suggest a release version when compared against the most recent version of this major: v3.53.4.

@asmyasnikov asmyasnikov merged commit e1a1bb5 into master Oct 23, 2023
45 of 48 checks passed
@asmyasnikov asmyasnikov deleted the fix-error-brief branch October 23, 2023 21:10
@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK database/sql:

Grafana Dashboard

SLO-databasesql

@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK gorm:

Grafana Dashboard

SLO-gorm

@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK native:

Grafana Dashboard

SLO-native

@github-actions
Copy link

🌋 Here are results of SLO test for Go SDK xorm:

Grafana Dashboard

SLO-xorm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants