Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable goerr113 linter #1147

Open
wants to merge 46 commits into
base: master
Choose a base branch
from

Conversation

PaulYakow
Copy link

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #941

What is the new behavior?

Other information

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 17.43119% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 41.13%. Comparing base (b7a9b51) to head (72e0952).
Report is 106 commits behind head on master.

Files Patch % Lines
internal/xsql/conn.go 0.00% 14 Missing ⚠️
...al/topic/topicreaderinternal/stream_reader_impl.go 18.18% 9 Missing ⚠️
.../topic/topicwriterinternal/writer_single_stream.go 0.00% 5 Missing ⚠️
internal/xsql/tx.go 0.00% 5 Missing ⚠️
balancers/config.go 50.00% 4 Missing ⚠️
internal/cmd/gstack/utils/utils.go 0.00% 4 Missing ⚠️
internal/xsql/dsn.go 0.00% 4 Missing ⚠️
internal/balancer/local_dc.go 0.00% 3 Missing ⚠️
...al/grpcwrapper/rawtopic/rawtopicwriter/messages.go 0.00% 3 Missing ⚠️
...rpcwrapper/rawtopic/rawtopicwriter/streamwriter.go 0.00% 3 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
+ Coverage   40.80%   41.13%   +0.33%     
==========================================
  Files         309      311       +2     
  Lines       32747    33039     +292     
==========================================
+ Hits        13361    13592     +231     
- Misses      18959    19014      +55     
- Partials      427      433       +6     
Flag Coverage Δ
go-1.21.x 43.31% <19.19%> (+0.38%) ⬆️
go-1.22.x 41.13% <17.43%> (+0.33%) ⬆️
macOS 42.70% <20.51%> (+2.40%) ⬆️
ubuntu 40.69% <18.60%> (+0.39%) ⬆️
unit 41.13% <17.43%> (+0.33%) ⬆️
windows 41.05% <17.43%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants