-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not hide pdisk and vdisk popups if mouse on popup content #1435
Merged
astandrik
merged 4 commits into
main
from
astandrik.do-not-hide-pdisk-and-vdisk-popups-1360
Oct 11, 2024
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ab2c179
fix: do not hide pdisk and vdisk popups if mouse on popup content
astandrik 00301ed
feat: add cell table delay
astandrik af0fa03
Merge branch 'main' into astandrik.do-not-hide-pdisk-and-vdisk-popups…
astandrik 8a28fa9
fix: review fixes
astandrik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -136,6 +136,13 @@ interface VDiskPopupProps extends PopupProps { | |
|
||
export const VDiskPopup = ({data, ...props}: VDiskPopupProps) => { | ||
const isFullData = isFullVDiskData(data); | ||
const [isPopupOpen, setIsPopupOpen] = React.useState(props.open); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
const onMouseLeave = React.useCallback(() => { | ||
setIsPopupOpen(false); | ||
}, []); | ||
const onMouseEnter = React.useCallback(() => { | ||
setIsPopupOpen(true); | ||
}, []); | ||
|
||
const vdiskInfo = React.useMemo( | ||
() => (isFullData ? prepareVDiskData(data) : prepareUnavailableVDiskData(data)), | ||
|
@@ -181,7 +188,10 @@ export const VDiskPopup = ({data, ...props}: VDiskPopupProps) => { | |
// bigger offset for easier switching to neighbour nodes | ||
// matches the default offset for popup with arrow out of a sense of beauty | ||
offset={[0, 12]} | ||
onMouseEnter={onMouseEnter} | ||
onMouseLeave={onMouseLeave} | ||
{...props} | ||
open={isPopupOpen || props.open} | ||
> | ||
{data.DonorMode && <Label className={b('donor-label')}>Donor</Label>} | ||
<InfoViewer title="VDisk" info={vdiskInfo} size="s" /> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's not stick to props value as initial. Let it be separate property lets say
[isPopupHovered, setIsPopupHovered] = React.useState(false)