Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change lock to interlocked atomics #59

Closed
wants to merge 5 commits into from
Closed

change lock to interlocked atomics #59

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ceeadb2
change lock to interlocked atomics
MadL1me Dec 16, 2023
c9b648d
Update src/Ydb.Sdk/src/Services/Table/Transaction.cs
asmyasnikov Feb 19, 2024
0ca39de
Update src/Ydb.Sdk/src/Services/Table/Transaction.cs
asmyasnikov Feb 19, 2024
82255ba
Update src/Ydb.Sdk/src/Services/Table/Transaction.cs
asmyasnikov Feb 19, 2024
3ae0675
Update src/Ydb.Sdk/src/Services/Table/Transaction.cs
rekby Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions src/Ydb.Sdk/src/Services/Table/Transaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ internal Transaction(string txId)
public string TxId { get; }

internal int? TxNum { get; private set; }

asmyasnikov marked this conversation as resolved.
Show resolved Hide resolved
private static int _txCounter;

internal static Transaction? FromProto(TransactionMeta proto, ILogger? logger = null)
{
Expand All @@ -23,26 +25,17 @@ internal Transaction(string txId)

var tx = new Transaction(
txId: proto.Id);

asmyasnikov marked this conversation as resolved.
Show resolved Hide resolved
if (!string.IsNullOrEmpty(proto.Id))
{
tx.TxNum = GetTxCounter();
tx.TxNum = IncTxCounter();
logger.LogTrace($"Received tx #{tx.TxNum}");
}

return tx;
}

private static readonly object TxCounterLock = new();
private static int _txCounter;

private static int GetTxCounter()
{
lock (TxCounterLock)
{
_txCounter++;
return _txCounter;
}
}

rekby marked this conversation as resolved.
Show resolved Hide resolved
private static int IncTxCounter() => Interlocked.Increment(ref _txCounter);
asmyasnikov marked this conversation as resolved.
Show resolved Hide resolved
}

public enum TransactionState
Expand Down
Loading