Fix transport error on delete session #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekby
reviewed
Nov 21, 2023
| @@ -24,7 +25,8 @@ internal ResultData(Session session) | |||
|
|
|||
| public Session Session { get; } | |||
|
|
|||
| internal static ResultData FromProto(CreateSessionResult resultProto, Driver driver, string endpoint) | |||
| internal static ResultData FromProto(CreateSessionResult resultProto, Driver driver, string endpoint, | |||
| bool settingsDeleteOnDispose) | |||
There was a problem hiding this comment.
The settingsDeleteOnDispose arg not used
| @@ -6,6 +6,7 @@ namespace Ydb.Sdk.Services.Table; | |||
|
|
|||
| public class CreateSessionSettings : OperationRequestSettings | |||
| { | |||
| public bool DeleteOnDispose = true; | |||
There was a problem hiding this comment.
when field DeleteSessionsOnDispose in class SessionPoolConfig is false
rekby
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Pull request type
Please check the type of change your PR introduces: