Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception throwing when results truncated #50

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

XmasApple
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

  • Add exception throwing when results truncated

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@XmasApple XmasApple requested a review from rekby October 17, 2023 10:50
@XmasApple XmasApple self-assigned this Oct 17, 2023
@@ -103,6 +104,10 @@ public partial class Session
if (status.IsSuccess && resultProto != null)
{
result = ExecuteDataQueryResponse.ResultData.FromProto(resultProto);
if (!settings.AllowTruncated && result.ResultSets.Any(set => set.Truncated))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests

# Conflicts:
#	CHANGELOG.md
#	src/Ydb.Sdk/src/Services/Table/ExecuteDataQuery.cs
#	src/Ydb.Sdk/tests/Utils.cs
@XmasApple XmasApple merged commit c8c50ce into main Oct 20, 2023
14 checks passed
@XmasApple XmasApple deleted the truncateException branch October 20, 2023 17:56
@XmasApple XmasApple removed their assignment Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants