Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreateAsync method and IDisposeAsync interface implementation #15

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

XmasApple
Copy link
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

using var driverOld = new Driver(driverConfig);
await driverOld.Initialize(); // easily forgotten

What is the new behavior?

await using var driverNew = await Driver.CreateAsync(driverConfig);

src/Ydb.Sdk/src/Driver.cs Outdated Show resolved Hide resolved
@rekby rekby merged commit 7980f65 into ydb-platform:main Aug 10, 2023
3 checks passed
@XmasApple XmasApple deleted the driverCreateAsync branch August 10, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants