fix statusName

ydb-platform · Aug 15, 2024 · c92bd28 · c92bd28
1 parent 3798d85
commit c92bd28
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/slo/src/AdoNet/SloContext.cs b/slo/src/AdoNet/SloContext.cs
@@ -16,7 +16,7 @@ public class SloContext : SloContext<YdbDataSource>
                 context["RetryCount"] = retryCount;
                 var errorsGauge = (Gauge)context["errorsGauge"];
 
-                errorsGauge?.WithLabels(((YdbException)e).Code.ToString(), "retried").Inc();
+                errorsGauge?.WithLabels(((YdbException)e).Code.StatusName(), "retried").Inc();
             });
 
     protected override string Job => "workload-ado-net";

diff --git a/slo/src/Internal/SloContext.cs b/slo/src/Internal/SloContext.cs
@@ -159,8 +159,8 @@ Task ShootingTask(RateLimiter rateLimitPolicy, string jobName,
             var errorsGauge = metricFactory.CreateGauge("errors", "amount of errors", new[] { "class", "in" });
             foreach (var statusCode in Enum.GetValues<StatusCode>())
             {
-                errorsGauge.WithLabels(statusCode.ToString(), "retried").IncTo(0);
-                errorsGauge.WithLabels(statusCode.ToString(), "finally").IncTo(0);
+                errorsGauge.WithLabels(statusCode.StatusName(), "retried").IncTo(0);
+                errorsGauge.WithLabels(statusCode.StatusName(), "finally").IncTo(0);
             }
 
             // ReSharper disable once MethodSupportsCancellation
@@ -264,4 +264,13 @@ private async Task MetricReset(string promPgwEndpoint)
         using var httpClient = new HttpClient();
         await httpClient.DeleteAsync(deleteUri);
     }
+}
+
+public static class StatusCodeExtension
+{
+    public static string StatusName(this StatusCode statusCode)
+    {
+        var prefix = statusCode >= StatusCode.ClientTransportResourceExhausted ? "GRPC" : "YDB";
+        return $"{prefix}_{statusCode}";
+    }
 }
diff --git a/slo/src/TableService/SloContext.cs b/slo/src/TableService/SloContext.cs
@@ -64,7 +64,7 @@ protected override async Task Create(TableClient client, string createTableSql,
                     return response;
                 }
 
-                errorsGauge?.WithLabels(response.Status.StatusCode.ToString(), "retried").Inc();
+                errorsGauge?.WithLabels(response.Status.StatusCode.StatusName(), "retried").Inc();
 
                 return response;
             });